Closed Bug 1711502 Opened 5 years ago Closed 4 years ago

Investigate why SVGContextPaint::IsAllowedForImageFromURI doesn't not seem to be called on Android builds when svg.context-properties.content.enabled is set to false

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: rpl, Unassigned)

References

Details

This is a follow up from Bug 1394579:

As described in a bit more detail in Bug 1394579 comment 28, the test case added as part of Bug 1394579 (test_ext_svg_context_fill.js) does currently fail on Android and it is not 100% clear what is preventing it to pass on Android builds as it does in Desktop builds.

Having the test_ext_svg_context_fill.js test file to run on Android wasn't a blocking issue for Bug 1394579, because at the moment we only need it to use it in Gecko-rendered frontend content, which is not used in GeckoView-based Android apps, and so we deferred to this follow up looking more into the reasons behind the unexpected different behavior that can be observed by running the test_ext_svg_context_fill.js test on Android.

For reference in the future, here's a link to a log showing the test-failure:
https://treeherder.mozilla.org/logviewer?job_id=339720988&repo=autoland&lineNumber=4124

And here's the contextual piece of the log from around this test & its failure:

[task 2021-05-14T12:27:57.672Z] 12:27:57  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | xpcshell return code: 0
[task 2021-05-14T12:27:57.672Z] 12:27:57     INFO -  TEST-INFO took 1065ms
[task 2021-05-14T12:27:57.672Z] 12:27:57     INFO -  >>>>>>>
[task 2021-05-14T12:27:57.672Z] 12:27:57     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-05-14T12:27:57.672Z] 12:27:57     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-05-14T12:27:57.673Z] 12:27:57     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-05-14T12:27:57.673Z] 12:27:57     INFO -  running event loop
[task 2021-05-14T12:27:57.673Z] 12:27:57     INFO -  xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | Starting check_remote
[task 2021-05-14T12:27:57.673Z] 12:27:57     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2021-05-14T12:27:57.673Z] 12:27:57     INFO -  TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - false == false
[task 2021-05-14T12:27:57.673Z] 12:27:57     INFO -  TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | check_remote - [check_remote : 1] testing from extension process - true == true
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  (xpcshell/head.js) | test check_remote finished (2)
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | Starting setup
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276918	addons.manager	DEBUG	Application has been upgraded"
[task 2021-05-14T12:27:57.674Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276918	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]"
[task 2021-05-14T12:27:57.675Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276919	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2021-05-14T12:27:57.675Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276919	addons.xpi	DEBUG	startup"
[task 2021-05-14T12:27:57.675Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276919	addons.xpi	INFO	SystemAddonLocation directory is missing"
[task 2021-05-14T12:27:57.675Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276927	addons.xpi	INFO	Removing all system add-on upgrades."
[task 2021-05-14T12:27:57.675Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276927	addons.xpi	DEBUG	checkForChanges"
[task 2021-05-14T12:27:57.675Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276927	addons.xpi	DEBUG	Loaded add-on state: ${}"
[task 2021-05-14T12:27:57.676Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276928	addons.xpi	DEBUG	scanForChanges changed: false, state: {}"
[task 2021-05-14T12:27:57.676Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276928	addons.xpi	DEBUG	Empty XPI database, setting schema version preference to 33"
[task 2021-05-14T12:27:57.676Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276928	addons.xpi	DEBUG	No changes found"
[task 2021-05-14T12:27:57.676Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276936	addons.xpi-utils	DEBUG	Synchronously loading the add-ons database"
[task 2021-05-14T12:27:57.676Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276936	addons.xpi-utils	DEBUG	Starting async load of XPI database /data/local/tmp/test_root/xpc/p/b34b2ff4-9af0-4200-8969-653f9122d33a/extensions.json"
[task 2021-05-14T12:27:57.676Z] 12:27:57     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276938	addons.xpi-utils	DEBUG	Rebuilding XPI database with no extensions"
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276939	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider"
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276939	addons.manager	DEBUG	Provider finished startup: XPIProvider"
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) 1620995276939	addons.manager	DEBUG	Completed startup sequence"
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  (xpcshell/head.js) | test run_next_test 2 pending (2)
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2021-05-14T12:27:57.677Z] 12:27:57     INFO -  xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | Starting test_allowed_on_privileged_ext
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  (xpcshell/head.js) | test test_allowed_on_privileged_ext pending (2)
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  "Extension attached"
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  (xpcshell/head.js) | test run_next_test 2 finished (2)
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "NotFoundError: Could not open the file at /data/local/tmp/test_root/xpc/p/b34b2ff4-9af0-4200-8969-653f9122d33a/startupCache/webext.sc.lz4"]
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  _do_main@/data/local/tmp/test_root/xpc/head.js:241:6
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  _execute_test@/data/local/tmp/test_root/xpc/head.js:598:5
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  @-e:1:1
[task 2021-05-14T12:27:57.678Z] 12:27:57     INFO -  "
[task 2021-05-14T12:27:57.679Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "moz-extension://cb13cd22-de6c-4388-bf85-9ccdbb66c833/page.html" line: 0}]"
[task 2021-05-14T12:27:57.679Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://mochikit/content/tests/SimpleTest/EventUtils.js"
[task 2021-05-14T12:27:57.679Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://mochikit/content/tests/SimpleTest/EventUtils.js"
[task 2021-05-14T12:27:57.679Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://mochikit/content/tests/SimpleTest/EventUtils.js"
[task 2021-05-14T12:27:57.679Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://mochikit/content/tests/SimpleTest/EventUtils.js"
[task 2021-05-14T12:27:57.680Z] 12:27:57     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "moz-extension://cb13cd22-de6c-4388-bf85-9ccdbb66c833/green-reference.html" line: 0}]"
[task 2021-05-14T12:27:57.681Z] 12:27:57  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_svg_context_fill.js | test_allowed_on_privileged_ext - [test_allowed_on_privileged_ext : 83] Context-fill should be allowed (resulting in green) on "privileged-addon@mochi.test" extension - "data:image/png;[...]

As discussed in https://phabricator.services.mozilla.com/D114957#3759794 , it seems likely this failure was actually just an intended outcome of bug 1708384 (which is a change that happened to land while this test was under development, resulting in an unexpected failure when the patch with the test was rebased and landed).

Hence, resolving this as invalid, since things are working-as-intended here. (Also, rpl ended up rewriting the test such that it's not susceptible to this failure, and the rewritten test will probably land soon over in https://phabricator.services.mozilla.com/D114957 )

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.