Closed
Bug 1711523
Opened 4 years ago
Closed 4 years ago
Remove `protonEnabled` private tracking in various frontend modules
Categories
(Firefox :: General, task, P3)
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [proton-cleanups])
Attachments
(1 file)
(As noted in bug 1709425, we should not land a patch for this before May 20th. Patches from deps of bug 1711467 to tests that read this pref will likely need to land first)
See this searchfox query: https://searchfox.org/mozilla-central/search?q=%5Cb_%3Fprotonenabled&path=&case=false®exp=true
which has the identity panel, monitor, UITour, URL bar code, page actions and devtools, all checking the proton prefs.
That code should stop checking those prefs. Code that only runs if the pref is false should be removed. Any private smart preference getters should be removed.
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1772
|
||
Updated•4 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9223583 -
Attachment description: WIP: Bug 1711523 - remove private proton tracking flags in frontend modules, r?mak!,emalysz! → Bug 1711523 - remove private proton tracking flags in frontend modules, r?mak!,emalysz!
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bb362e72835e
remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
|
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•