1711538 - Improve 'compatible_type()'

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This renames compatible_type() to can_implicitly_convert_to()
which is a better name. The parameters are also renamed to make
it more obvious what's going on. Finally, implicit conversion
of float/double to int is removed because that's not supported
by glsl.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1711538 - Improve 'compatible_type()'

This renames compatible_type() to can_implicitly_convert_to()
which is a better name. The parameters are renamed to make
it more obvious what's going on. A note is added about
glsl misparsing of float literals and finally, implicit conversion of
float/double to int is removed because that's not supported by glsl.

These changes let us undo the scoring changes that were added bug
1674396 because we don't accidentally end up with int versions of
functions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ab369b87f17
Improve 'compatible_type()' r=lsalzman

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8ab369b87f17