1711573 - Revert NimbusFeatures.upgradeDialog to use its own feature

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement)

Description

[Ed Lee :Mardak]

Bug 1710460 comment 3 noted that upgradeDialog was not totally suitable for an experiment enrolling 88 users as it was not "sync" (or even defined) in that release. Bug 1710955 gets it working in 88 by aliasing/reusing the aboutwelcome feature so that the experiment value will be available (via pref) during 89 startup.

We want to separate the two upgradeDialog and aboutwelcome as originally intended. Potentially we can do so before the end of 90 nightly if we're okay with users upgrading from 89 to 90 seeing the upgrade dialog because when reverted, upgradeDialog will be enabled instead of looking at the holdback's aboutwelcome enabled:false value.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1711573 - Revert NimbusFeatures.upgradeDialog to use its own feature r?k88hudson

Release 88 users are already enrolling in nimbus onboarding-modal-experiment which uses aboutwelcome feature. Enrollment ends 2021-05-31 and observation will be 4 weeks until 2021-06-28, which ends before 90 reaches release 2021-07-13, so enrolled users will naturally unenroll before upgrading to 90, which would no longer have this feature alias.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd51afd65ec6
Revert NimbusFeatures.upgradeDialog to use its own feature r=k88hudson

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fd51afd65ec6