1711626 - [Bug] Password fields should not automatically start with capital letter with Samsung keyboard

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P3)

Description

[Makoto Kato [:m_kato]]

From github: https://github.com/mozilla-mobile/fenix/issues/19335.

Steps to reproduce

Go to any page with a password field eg Gmail.com
Select the password field
Android keyboard automatically opens with Caps selected for the first letter

Expected behavior

Do not default to starting with a capital letter for passwords

Actual behavior

Android keyboard automatically opens with Caps selected for the first letter

Device information

• Device vendor / model and Android version: Samsung galaxy tab s6 Android v11
• Firefox for Android version: ? (go to Settings -> About Firefox) 88.1.2

I know that this is a setting on my keyboard to capitalise the first letter. I am assuming that this can be overridden by applications

Change performed by the Move to Bugzilla add-on.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1711626 - Don't set InputType.TYPE_TEXT_FLAG_CAP_SENTENCES for some types. r=#geckoview-reviewers

Actually, we set auto-capitalize flag if current <input> element isn't text
due to bug 871884.

Most 3rd party keyboard ignores this flag if it is password. But Samsung's
default keyboard uses this flag even if this is password.

So we shouldn't set auto-capitalize flag if <input> element is password.

Also, we also set this on type=email and type=url. But when I check Chrome
behaviour, they don't set this flag on these types. So I would like not to set
this flag to these types too.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e01bf80dc0be
Don't set InputType.TYPE_TEXT_FLAG_CAP_SENTENCES for some types. r=geckoview-reviewers,agi

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e01bf80dc0be

Comment 4

[Chris Peterson [:cpeterson]]

Moving some keyboard bugs to the new GeckoView::IME component.