1711719 - Locking browser.newtabpage.enabled doesn't disable the new tab dropdown in preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Mike Kaply [:mkaply]]

If you lock browser.newtabpage.enabled:

pref("browser.newtabpage.enabled", false, locked);

in firefox.js for instance,

It should disable the UI in preferences.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1711719 - Disable new tab menulist if preference is locked. r?Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4eff9f3373a
Disable new tab menulist if preference is locked. r=Gijs,preferences-reviewers

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b4eff9f3373a

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9272121 [details]
Bug 1711719 - Disable new tab menulist if preference is locked. r?Gijs

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Parity with 101
• User impact if declined: New tab pref is changeable even when locked (doesn't have an effect)
• Fix Landed on Version: 101
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small isolated change.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9272121 [details]
Bug 1711719 - Disable new tab menulist if preference is locked. r?Gijs

Approved for 91.10esr.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/4a79264e22c3

Comment 7

[Virgil Sangerean]

Verified fix on 101.0 Firefox and 91.10.0 esr FF versions.