Closed Bug 1711719 Opened 3 years ago Closed 2 years ago

Locking browser.newtabpage.enabled doesn't disable the new tab dropdown in preferences

Categories

(Firefox :: Settings UI, defect, P2)

defect

Tracking

()

VERIFIED FIXED
101 Branch
Tracking Status
firefox-esr91 --- verified
firefox101 --- verified

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

If you lock browser.newtabpage.enabled:

pref("browser.newtabpage.enabled", false, locked);

in firefox.js for instance,

It should disable the UI in preferences.

Severity: S2 → S3
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/b4eff9f3373a
Disable new tab menulist if preference is locked. r=Gijs,preferences-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

Comment on attachment 9272121 [details]
Bug 1711719 - Disable new tab menulist if preference is locked. r?Gijs

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Parity with 101
  • User impact if declined: New tab pref is changeable even when locked (doesn't have an effect)
  • Fix Landed on Version: 101
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very small isolated change.
Attachment #9272121 - Flags: approval-mozilla-esr91?

Comment on attachment 9272121 [details]
Bug 1711719 - Disable new tab menulist if preference is locked. r?Gijs

Approved for 91.10esr.

Attachment #9272121 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified fix on 101.0 Firefox and 91.10.0 esr FF versions.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: