Closed Bug 1711788 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 29033 - [GridNG] Updating grid container baseline logic

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29033 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29033
Details from upstream follow.

b'Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com>' wrote:

[GridNG] Updating grid container baseline logic

This change updates the grid container baseline logic so that we pass
grid-baseline-004.html. In particular, spanning items should not be
considered for baseline fallbacks, and the fallback baseline should
never be considered if we have an actual baseline aligned item.

The grid-baseline-004.html also has some minor updates:

  1. The .exepected.txt file was removed, so legacy grid now fails
  2. Some of the expected offsets appear incorrect. These were updated
    to match GridNG (with this change) and Firefox expectations.

Bug: 1045599
Change-Id: Ic95f9811fce0286810b033b40e7fe6b3fb614fa7
Reviewed-on: https://chromium-review.googlesource.com/2903732
WPT-Export-Revision: 18ec9d52efbbb301c9c193d389c71bd711be9cda

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 18 subtests

Status Summary

Firefox

OK : 1
PASS: 11
FAIL: 7

Chrome

OK : 1
PASS: 15
FAIL: 3

Safari

OK : 1
PASS: 13
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-grid/alignment/grid-baseline-004.html
.grid, container 4: FAIL linked bug:Bug 1650906
.grid, container 5: FAIL linked bug:Bug 1650906
.grid, container 6: FAIL linked bug:Bug 1650906
.grid, container 10: FAIL linked bug:Bug 1650906
.grid, container 12: FAIL linked bug:Bug 1650906

New Tests That Don't Pass

/css/css-grid/alignment/grid-baseline-004.html
.grid, container 4: FAIL (Chrome: PASS, Safari: PASS)
.grid, container 5: FAIL (Chrome: PASS, Safari: PASS)
.grid, container 6: FAIL (Chrome: PASS, Safari: PASS)
.grid, container 10: FAIL (Chrome: PASS, Safari: PASS)
.grid, container 11: FAIL (Chrome: PASS, Safari: FAIL)
.grid, container 12: FAIL (Chrome: PASS, Safari: PASS)
.grid, container 17: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57dac6edfb03 [wpt PR 29033] - [GridNG] Updating grid container baseline logic, a=testonly

https://hg.mozilla.org/mozilla-central/rev/57dac6edfb03

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.