Closed Bug 1711796 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29034 - MSE: Reject mpeg audio BSF type support if codecs parameter included

Categories

(Core :: Audio/Video: Playback, task, P4)

Product:
Core
Component:
Audio/Video: Playback
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29034 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29034
Details from upstream follow.

b'Matt Wolenetz <wolenetz@chromium.org>' wrote:

MSE: Reject mpeg audio BSF type support if codecs parameter included

Fixes a Chromium CHECK failure involved in MSE type support checks for
types requiring implicit codecs (specifically, types that map to the
MPEG audio bytestream format specification [1]), yet a codecs parameter
was included and passes preliminary HTMLMediaElement type support
checks.

Adds internal MSE content_browsertests to better confirm the behavior in
the referenced crbug is fixed.

Also adds interop MediaSource web-platform-tests to ensure
implementations report lack of support for mpeg audio bytestream format
type queries that include an explicit codec. Codecs parameters used in
these tests are not exhaustive, though are wider than the internal
browsertests added, above.

[1] https://www.w3.org/TR/mse-byte-stream-format-mpeg-audio/#mime-types

Fixed: 1210281
Change-Id: Ic4a7f78e4420c5a0ce9ba306f1ca7d74ad790d43
Reviewed-on: https://chromium-review.googlesource.com/2904509
WPT-Export-Revision: 1f76762e2e94e12d45d94a2234de0194da5fd4ca

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 53 subtests

Status Summary

Firefox

OK : 1
PASS: 46
FAIL: 7

Chrome

OK : 1
PASS: 53

Safari

OK : 1
PASS: 35
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/media-source/mediasource-is-type-supported.html
Test invalid MIME format "video/webm": FAIL
Test invalid MIME format "video/webm;": FAIL
Test invalid MIME format "video/webm;codecs": FAIL
Test invalid MIME format "video/webm;codecs=": FAIL
Test invalid MIME format "video/webm;codecs="": FAIL
Test invalid MIME format "video/webm;codecs=""": FAIL
Test invalid MIME format "audio/webm;aaacodecsbbb=opus": FAIL

New Tests That Don't Pass

/media-source/mediasource-is-type-supported.html
Test invalid MIME format "video/webm": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs=": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs="": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs=""": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "audio/webm;aaacodecsbbb=opus": FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dcb796c54c5
[wpt PR 29034] - MSE: Reject mpeg audio BSF type support if codecs parameter included, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9dcb796c54c5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.