1711833 - [gcc 11] error: 'char* __builtin_strncpy(char*, const char*, long unsigned int)' specified bound 33 equals destination

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Mike Hommey [:glandium]]

[task 2021-05-19T04:07:28.318Z] 04:07:28     INFO -  In file included from /builds/worker/fetches/sysroot/usr/include/string.h:640,
[task 2021-05-19T04:07:28.318Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/system_wrappers/string.h:3,
[task 2021-05-19T04:07:28.318Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/include/mozilla/throw_gcc.h:14,
[task 2021-05-19T04:07:28.319Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/stl_wrappers/type_traits:80,
[task 2021-05-19T04:07:28.319Z] 04:07:28     INFO -                   from /builds/worker/fetches/gcc/include/c++/11.1.0/bits/move.h:57,
[task 2021-05-19T04:07:28.319Z] 04:07:28     INFO -                   from /builds/worker/fetches/gcc/include/c++/11.1.0/bits/stl_pair.h:59,
[task 2021-05-19T04:07:28.319Z] 04:07:28     INFO -                   from /builds/worker/fetches/gcc/include/c++/11.1.0/utility:70,
[task 2021-05-19T04:07:28.320Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/system_wrappers/utility:3,
[task 2021-05-19T04:07:28.320Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/stl_wrappers/utility:60,
[task 2021-05-19T04:07:28.320Z] 04:07:28     INFO -                   from /builds/worker/fetches/gcc/include/c++/11.1.0/algorithm:60,
[task 2021-05-19T04:07:28.320Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/system_wrappers/algorithm:3,
[task 2021-05-19T04:07:28.320Z] 04:07:28     INFO -                   from /builds/worker/workspace/obj-build/dist/stl_wrappers/algorithm:60,
[task 2021-05-19T04:07:28.321Z] 04:07:28     INFO -                   from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/ice_unittest.cpp:9:
[task 2021-05-19T04:07:28.321Z] 04:07:28     INFO -  In function 'char* strncpy(char*, const char*, size_t)',
[task 2021-05-19T04:07:28.321Z] 04:07:28     INFO -      inlined from 'void {anonymous}::WebRtcIcePrioritizerTest::AddInterface(const string&, int, int)' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/ice_unittest.cpp:1901:12:
[task 2021-05-19T04:07:28.321Z] 04:07:28    ERROR -  /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:34: error: 'char* __builtin_strncpy(char*, const char*, long unsigned int)' specified bound 33 equals destination size [-Werror=stringop-truncation]
[task 2021-05-19T04:07:28.322Z] 04:07:28     INFO -    120 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T04:07:28.322Z] 04:07:28     INFO -        |          ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T04:07:28.322Z] 04:07:28     INFO -  cc1plus: all warnings being treated as errors

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1711833 - Fix GCC warning about the use of strncpy in WebRtcIcePrioritizerTest::AddInterface.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1711833 - Let the compiler generate the Matrix4x4Typed copy assignment operator.

This avoids GCC complaining about the case where doing m = m would
memcpy from an address onto itself.

Comment 3

[Phabricator Automation]

Comment on attachment 9222560 [details]
Bug 1711833 - Let the compiler generate the Matrix4x4Typed copy assignment operator.

Revision D115460 was moved to bug 1711834. Setting attachment 9222560 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88188df5ca6b
Fix GCC warning about the use of strncpy in WebRtcIcePrioritizerTest::AddInterface. r=mjf

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/88188df5ca6b