1711845 - Fix the request side panel empty params text

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[contact]

Attachment: bug firefox 1.JPG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

When an ajax request (XHR) is sending in "GET" mode the "params" is not visible and still empty. But all is working well in "POST" mode.
The problem is present on "console" and "network" menu.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Bonjour! Thanks for the report.
Is this happening on all requests? It looks like the request in the screenshot is taking a while (> 7s), and I wonder if that could cause the issue here.
Did you expand the request before it's completed? If you have control over releves_data.php, what happens if you return an empty array (so it doesn't take as long).
Also, would you be able to test again Firefox Nightly? I think we fixed a similar issue not long ago, so it would be nice to check if it's different.

Merci :)

Comment 2

[contact]

Yes it's happend on all requests, on the screenshot it was normal for the 7s delay, it's a big data file to return. But the problem is also present on google or other website for exemple, but only for GET xhr.

Few weeks ago the problem didn't exist, but in the past I remember that antoher problem appends on xhr GET request too (the params was not separated and was in one line, but now the new bug is different because params is totaly empty) I am not sure but I think it's happened recently on the latests versions.

Thanks

Comment 3

[contact]

Attachment: firefox bug 2.JPG

Bug on all requests, like google for exemple

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2021-05-19 at 11.29.41.png

The GET parameters are now displayed in the Headers (En-tête) panel, below the URL
The Request panel only shows the Form data now

The wording of the panel title + the "empty" text can be confusing, let's see if we can do better

Comment 5

[contact]

Ah great thanks for the screenshot, I had not seen that the params of "get" was here, but now I understand why in "Request" you have only the form params, and in headers the url params, it seems logical.

Merci :)

Comment 6

[Julian Descottes [:jdescottes]]

Bomsy: find proper title and next steps

Comment 7

[Hubert Boma Manilla (:bomsy)]

Based on the discussions, lets update the text which shows when there are request parameters which is currently "No parameters for this request" to something more specific, maybe "No payload body for this request" or just "No payload for this request".

Honza,
Did you have some suggestions on the text content as well?

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me) PTO July 8 - 26]

"No payload for this request" sound great

Comment 9

[jha.ashray12]

Hello, I would like to work on this issue, some guide from your side will be great :)

Comment 10

[Hubert Boma Manilla (:bomsy)]

Hi,
I've assigned to you.

This is where the text needs to change
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/devtools/client/locales/en-US/netmonitor.properties#96

Also this test needs to be fixed.
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/devtools/client/netmonitor/test/browser_net_complex-params.js#305-309

Thanks

Comment 11

[jha.ashray12]

Thanks for assigning, it would be great if you tell me how to reproduce the issue and how to fix the test that you mentioned in https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/devtools/client/netmonitor/test/browser_net_complex-params.js#305-309.
Thanks :)

Comment 12

[Hubert Boma Manilla (:bomsy)]

HI jha,

Have you setup Firefox for development? If not see https://firefox-source-docs.mozilla.org/devtools/index.html#contributing

To reproduce,

1. Go to any google.com
2. Open devtools and the netmonitor
3. Select the first request and click the request side panel
4. The request panel empty text is No parameters for this request

On Fixing the the test, you just need to change the text to match the new text suggested in Comment 7
to run the test do ./mach test browser_net_complex-params.js

Comment 13

[jha.ashray12]

Attachment: Bug 1711845 - Fix empty params text in request side panel. r?bomsy

Comment 14

[jha.ashray12]

Hello @bomsy, kindly review my patch .
Thanks! :)

Comment 15

[Hubert Boma Manilla (:bomsy)]

The patch looks good! good work! Let's wait for try to finish before we land.

Thanks

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75cea270f7d7
Fix empty params text in request side panel. r=bomsy

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/75cea270f7d7