Closed
Bug 1711846
Opened 3 years ago
Closed 3 years ago
[gcc 11] Multiple stringop-overflow and stringop-truncation warnings in nICEr and nrappkit
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - In file included from /builds/worker/fetches/sysroot/usr/include/string.h:640,
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - from /builds/worker/workspace/obj-build/dist/system_wrappers/string.h:3,
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:47,
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - from Unified_c_nrappkit0.c:2:
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - In function 'strncpy',
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - inlined from 'NR_reg_get_child_registry' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.c:243:9:
[task 2021-05-19T07:14:27.582Z] 07:14:27 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin_strncpy' specified bound 128 equals destination size [-Werror=stringop-truncation]
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - In file included from Unified_c_nrappkit0.c:101:
[task 2021-05-19T07:14:27.582Z] 07:14:27 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registrycb.c: In function 'NR_reg_register_callback':
[task 2021-05-19T07:14:27.583Z] 07:14:27 WARNING - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/libekr/r_memory.c:119:20: warning: 'info' may be used uninitialized in this function [-Wmaybe-uninitialized]
[task 2021-05-19T07:14:27.583Z] 07:14:27 INFO - 119 | mem_stats[chunk->type]-=chunk->size;
[task 2021-05-19T07:14:27.583Z] 07:14:27 INFO - | ~~~~~^~~~~~
[task 2021-05-19T07:14:27.583Z] 07:14:27 INFO - In file included from Unified_c_nrappkit0.c:38:
[task 2021-05-19T07:14:27.583Z] 07:14:27 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registrycb.c:123:21: note: 'info' was declared here
[task 2021-05-19T07:14:27.584Z] 07:14:27 INFO - 123 | nr_reg_cb_info *info;
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - | ^~~~
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - In file included from /builds/worker/fetches/sysroot/usr/include/string.h:640,
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - from /builds/worker/workspace/obj-build/dist/system_wrappers/string.h:3,
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:47,
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - from Unified_c_nrappkit0.c:2:
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - In function 'strncpy',
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - inlined from 'nr_reg_local_get_type' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry_local.c:970:5:
[task 2021-05-19T07:14:27.586Z] 07:14:27 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin_strncpy' specified bound 32 equals destination size [-Werror=stringop-truncation]
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:27.586Z] 07:14:27 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - In function 'strncpy',
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - inlined from 'r_vlog_e.part.0' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:428:7:
[task 2021-05-19T07:14:27.587Z] 07:14:27 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin___strncpy_chk' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - In file included from Unified_c_nrappkit0.c:2:
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c: In function 'r_vlog_e.part.0':
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:423:23: note: length computed here
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - 423 | int formatlen = strlen(format);
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - | ^~~~~~~~~~~~~~
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - In file included from /builds/worker/fetches/sysroot/usr/include/string.h:640,
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - from /builds/worker/workspace/obj-build/dist/system_wrappers/string.h:3,
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:47,
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - from Unified_c_nrappkit0.c:2:
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - In function 'strncpy',
[task 2021-05-19T07:14:27.587Z] 07:14:27 INFO - inlined from 'r_vlog_nr.part.0' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:462:7:
[task 2021-05-19T07:14:27.588Z] 07:14:27 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin___strncpy_chk' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - In file included from Unified_c_nrappkit0.c:2:
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c: In function 'r_vlog_nr.part.0':
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/log/r_log.c:458:23: note: length computed here
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - 458 | int formatlen = strlen(format);
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - | ^~~~~~~~~~~~~~
[task 2021-05-19T07:14:27.588Z] 07:14:27 INFO - cc1: all warnings being treated as errors
[task 2021-05-19T07:14:28.356Z] 07:14:28 INFO - In file included from /builds/worker/fetches/sysroot/usr/include/string.h:640,
[task 2021-05-19T07:14:28.356Z] 07:14:28 INFO - from /builds/worker/workspace/obj-build/dist/system_wrappers/string.h:3,
[task 2021-05-19T07:14:28.356Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/port/linux/include/linux_funcs.h:46,
[task 2021-05-19T07:14:28.357Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/port/linux/include/csi_platform.h:43,
[task 2021-05-19T07:14:28.357Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:33,
[task 2021-05-19T07:14:28.357Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.358Z] 07:14:28 INFO - In function 'strncpy',
[task 2021-05-19T07:14:28.358Z] 07:14:28 INFO - inlined from 'get_siocgifflags' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:86:3,
[task 2021-05-19T07:14:28.358Z] 07:14:28 INFO - inlined from 'stun_convert_netlink' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:139:15,
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - inlined from 'stun_getaddrs_filtered' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:251:22:
[task 2021-05-19T07:14:28.370Z] 07:14:28 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin_strncpy' output may be truncated copying 15 bytes from a string of length 32 [-Werror=stringop-truncation]
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - In function 'strncpy',
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - inlined from 'stun_convert_netlink' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:153:3,
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - inlined from 'stun_getaddrs_filtered' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:251:22:
[task 2021-05-19T07:14:28.370Z] 07:14:28 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin_strncpy' output may be truncated copying 16 bytes from a string of length 32 [-Werror=stringop-truncation]
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.370Z] 07:14:28 INFO - In function 'strncpy',
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - inlined from 'stun_convert_netlink' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:173:3,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - inlined from 'stun_getaddrs_filtered' at /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-netlink.c:251:22:
[task 2021-05-19T07:14:28.371Z] 07:14:28 ERROR - /builds/worker/fetches/sysroot/usr/include/x86_64-linux-gnu/bits/string3.h:120:10: error: '__builtin_strncpy' output may be truncated copying 16 bytes from a string of length 32 [-Werror=stringop-truncation]
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - 120 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:74:
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c: In function 'nr_stun_client_ctx_create':
[task 2021-05-19T07:14:28.371Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:76:16: error: 'NR_reg_get_uint4' accessing 128 bytes in a region of size 35 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - 76 | } else if (NR_reg_get_uint4(NR_STUN_REG_PREF_CLNT_RETRANSMIT_TIMEOUT, &ctx->rto_ms)) {
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:76:16: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:73:5: note: in a call to function 'NR_reg_get_uint4'
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - 73 | int NR_reg_get_uint4(NR_registry name, UINT4 *out);
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:74:
[task 2021-05-19T07:14:28.371Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:80:9: error: 'NR_reg_get_double' accessing 128 bytes in a region of size 42 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - 80 | if (NR_reg_get_double(NR_STUN_REG_PREF_CLNT_RETRANSMIT_BACKOFF, &ctx->retransmission_backoff_factor))
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:80:9: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:76:5: note: in a call to function 'NR_reg_get_double'
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - 76 | int NR_reg_get_double(NR_registry name, double *out);
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:74:
[task 2021-05-19T07:14:28.371Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:83:9: error: 'NR_reg_get_uint4' accessing 128 bytes in a region of size 30 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - 83 | if (NR_reg_get_uint4(NR_STUN_REG_PREF_CLNT_MAXIMUM_TRANSMITS, &ctx->maximum_transmits))
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:83:9: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.371Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:73:5: note: in a call to function 'NR_reg_get_uint4'
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - 73 | int NR_reg_get_uint4(NR_registry name, UINT4 *out);
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:74:
[task 2021-05-19T07:14:28.372Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:86:9: error: 'NR_reg_get_uint4' accessing 128 bytes in a region of size 37 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - 86 | if (NR_reg_get_uint4(NR_STUN_REG_PREF_CLNT_FINAL_RETRANSMIT_BACKOFF, &ctx->maximum_transmits_timeout_ms))
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:86:9: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.372Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:73:5: note: in a call to function 'NR_reg_get_uint4'
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - 73 | int NR_reg_get_uint4(NR_registry name, UINT4 *out);
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:74:
[task 2021-05-19T07:14:28.373Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:90:9: error: 'NR_reg_get_char' accessing 128 bytes in a region of size 20 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - 90 | if (NR_reg_get_char(NR_STUN_REG_PREF_ALLOW_LOOPBACK_ADDRS, &allow_loopback) ||
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_client_ctx.c:90:9: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:68:5: note: in a call to function 'NR_reg_get_char'
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - 68 | int NR_reg_get_char(NR_registry name, char *out);
[task 2021-05-19T07:14:28.373Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.374Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:110:
[task 2021-05-19T07:14:28.374Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_proc.c: In function 'nr_stun_add_realm_and_nonce.isra':
[task 2021-05-19T07:14:28.374Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_proc.c:402:12: error: 'NR_reg_alloc_string' accessing 128 bytes in a region of size 18 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.374Z] 07:14:28 INFO - 402 | if ((r=NR_reg_alloc_string(NR_STUN_REG_PREF_SERVER_REALM, &realm)))
[task 2021-05-19T07:14:28.374Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.374Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_proc.c:402:12: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.374Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.375Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.375Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.376Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:142:5: note: in a call to function 'NR_reg_alloc_string'
[task 2021-05-19T07:14:28.376Z] 07:14:28 INFO - 142 | int NR_reg_alloc_string(NR_registry name, char **data);
[task 2021-05-19T07:14:28.376Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.377Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:110:
[task 2021-05-19T07:14:28.377Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_proc.c:413:17: error: 'NR_reg_get_uint2' accessing 128 bytes in a region of size 23 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.378Z] 07:14:28 INFO - 413 | if (NR_reg_get_uint2(NR_STUN_REG_PREF_SERVER_NONCE_SIZE, &size))
[task 2021-05-19T07:14:28.378Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.379Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_proc.c:413:17: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.379Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.379Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.380Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.380Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:71:5: note: in a call to function 'NR_reg_get_uint2'
[task 2021-05-19T07:14:28.381Z] 07:14:28 INFO - 71 | int NR_reg_get_uint2(NR_registry name, UINT2 *out);
[task 2021-05-19T07:14:28.381Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.381Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:65:
[task 2021-05-19T07:14:28.381Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_build.c: In function 'nr_stun_form_error_response':
[task 2021-05-19T07:14:28.382Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_build.c:607:10: error: 'NR_reg_get_string' accessing 128 bytes in a region of size 17 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.382Z] 07:14:28 INFO - 607 | if (!NR_reg_get_string(NR_STUN_REG_PREF_SERVER_NAME, server_name, sizeof(server_name))) {
[task 2021-05-19T07:14:28.382Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.383Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_build.c:607:10: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.383Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.384Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.384Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.384Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:80:5: note: in a call to function 'NR_reg_get_string'
[task 2021-05-19T07:14:28.384Z] 07:14:28 INFO - 80 | int NR_reg_get_string(NR_registry name, char *out, size_t size);
[task 2021-05-19T07:14:28.385Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.385Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:65:
[task 2021-05-19T07:14:28.385Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_build.c: In function 'nr_stun_form_success_response':
[task 2021-05-19T07:14:28.386Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_build.c:547:10: error: 'NR_reg_get_string' accessing 128 bytes in a region of size 17 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.386Z] 07:14:28 INFO - 547 | if (!NR_reg_get_string(NR_STUN_REG_PREF_SERVER_NAME, server_name, sizeof(server_name))) {
[task 2021-05-19T07:14:28.386Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.386Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_build.c:547:10: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.387Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.387Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.387Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.388Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:80:5: note: in a call to function 'NR_reg_get_string'
[task 2021-05-19T07:14:28.388Z] 07:14:28 INFO - 80 | int NR_reg_get_string(NR_registry name, char *out, size_t size);
[task 2021-05-19T07:14:28.389Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.389Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:128:
[task 2021-05-19T07:14:28.390Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_util.c: In function 'nr_stun_filter_local_addresses':
[task 2021-05-19T07:14:28.391Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_util.c:122:12: error: 'NR_reg_get_char' accessing 128 bytes in a region of size 20 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.392Z] 07:14:28 INFO - 122 | if ((r=NR_reg_get_char(NR_STUN_REG_PREF_ALLOW_LOOPBACK_ADDRS,
[task 2021-05-19T07:14:28.392Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.393Z] 07:14:28 INFO - 123 | &allow_loopback))) {
[task 2021-05-19T07:14:28.393Z] 07:14:28 INFO - | ~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.394Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_util.c:122:12: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.395Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.395Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.395Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.396Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:68:5: note: in a call to function 'NR_reg_get_char'
[task 2021-05-19T07:14:28.396Z] 07:14:28 INFO - 68 | int NR_reg_get_char(NR_registry name, char *out);
[task 2021-05-19T07:14:28.397Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.397Z] 07:14:28 INFO - In file included from Unified_c_third_party_nICEr1.c:128:
[task 2021-05-19T07:14:28.397Z] 07:14:28 ERROR - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_util.c:129:12: error: 'NR_reg_get_char' accessing 128 bytes in a region of size 22 [-Werror=stringop-overflow=]
[task 2021-05-19T07:14:28.398Z] 07:14:28 INFO - 129 | if ((r=NR_reg_get_char(NR_STUN_REG_PREF_ALLOW_LINK_LOCAL_ADDRS,
[task 2021-05-19T07:14:28.398Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.398Z] 07:14:28 INFO - 130 | &allow_link_local))) {
[task 2021-05-19T07:14:28.399Z] 07:14:28 INFO - | ~~~~~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.399Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/stun_util.c:129:12: note: referencing argument 1 of type 'char *'
[task 2021-05-19T07:14:28.400Z] 07:14:28 INFO - In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h:43,
[task 2021-05-19T07:14:28.400Z] 07:14:28 INFO - from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/net/transport_addr_reg.c:49,
[task 2021-05-19T07:14:28.400Z] 07:14:28 INFO - from Unified_c_third_party_nICEr1.c:2:
[task 2021-05-19T07:14:28.401Z] 07:14:28 INFO - /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nrappkit/src/registry/registry.h:68:5: note: in a call to function 'NR_reg_get_char'
[task 2021-05-19T07:14:28.401Z] 07:14:28 INFO - 68 | int NR_reg_get_char(NR_registry name, char *out);
[task 2021-05-19T07:14:28.401Z] 07:14:28 INFO - | ^~~~~~~~~~~~~~~
[task 2021-05-19T07:14:28.402Z] 07:14:28 INFO - cc1: all warnings being treated as errors
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9222570 -
Attachment description: Bug 1711846 - Disable stringop-overflow and stringop-overflow warnings in third party nICEr and nrappkit code. → Bug 1711846 - Disable stringop-overflow and stringop-truncation warnings in third party nICEr and nrappkit code.
|
|
Assignee | |
Updated•3 years ago
|
Summary: Multiple stringop-overflow and stringop-truncation warnings in nICEr and nrappkit → [gcc 11] Multiple stringop-overflow and stringop-truncation warnings in nICEr and nrappkit
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/eb2681924682 Disable stringop-overflow and stringop-truncation warnings in third party nICEr and nrappkit code. r=mjf,firefox-build-system-reviewers,mhentges
|
|
Assignee | |
Comment 3•3 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/8dcadc62136d Followup: also disable stringop-overflow warnings in nrappkit code.
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•