Closed Bug 1711958 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29050 - Avoid potential dangling pointer access in computed accessible nodes

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29050 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29050
Details from upstream follow.

b'Aaron Leventhal <aleventhal@google.com>' wrote:

Avoid potential dangling pointer access in computed accessible nodes

Remove raw pointer and use an accessor instead. This will prevent
use-after-free in a robust way. It's impossible for any new getters
to do anything worse than a null pointer reference.

Bug: 1209118
Change-Id: Ied410c54f35e0d99f5d7a14bac9fd7563e9e87d5
Reviewed-on: https://chromium-review.googlesource.com/2903506
WPT-Export-Revision: 06fe430db416ca64a1e6d3d3ba8cc895762f18ba

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

CRASH : 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/accessibility/crashtests/aom-in-destroyed-iframe.html: TIMEOUT (Chrome: CRASH, Safari: TIMEOUT)

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b70b0ffeb367 [wpt PR 29050] - Avoid potential dangling pointer access in computed accessible nodes, a=testonly https://hg.mozilla.org/integration/autoland/rev/c52030d66787 [wpt PR 29050] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5435ada07ac5 [wpt PR 29050] - Avoid potential dangling pointer access in computed accessible nodes, a=testonly https://hg.mozilla.org/integration/autoland/rev/b3ac1ac10b12 [wpt PR 29050] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee03a44d8652 [wpt PR 29050] - Avoid potential dangling pointer access in computed accessible nodes, a=testonly https://hg.mozilla.org/integration/autoland/rev/2dedb7259ff2 [wpt PR 29050] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ee03a44d8652
https://hg.mozilla.org/mozilla-central/rev/2dedb7259ff2

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.