1712002 - dropping of addresses from Address Book into a compose window address field is handled twice

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Nuno Silva [:njsg]]

As frg observed, dragging and dropping contacts from the address book into a compose window address field does not produce the expected result - if contacts abc, def and xyz are selected, and dropped in the first empty address field, the result will be something like:

To: abcabc, def, xyz
To: def
To: xyz

This is present in 2.53.9b1pre and also in 2.49.5. This appears to be caused by the drop event being handled twice. The field where the selection is dropped gets the corresponding address (in this case abc), and the whole selection as a comma-separated list. If "abc" is long enough, and depending on the drop location inside the field, the comma-separated list may appear in the middle of "abc". Using "undo" in the affected field then shows "abc".

This was bug 1267804 for Thunderbird, and adding event.preventDefault() before "if (onWidget)" inside DropOnAddressingTarget() (see bug 1708999) seems to help.

Comment 1

[Nuno Silva [:njsg]]

Attachment: 1712002-preventDefault

Is something like this sufficient? Should it also call stopPropagation() somewhere?

Comment 2

[Ian Neal]

Attachment: 1712002-preventDefault-v1_1-2538.patch

Something like this for the stopPropagation?

Comment 3

[Nuno Silva [:njsg]]

Attachment: 1712002-preventDefault-v1_2-2538.patch

A newer version from the patch queue with the modifications discussed here and on IRC.

Comment 4

[Ian Neal]

Comment on attachment 9223133 [details] [diff] [review]
1712002-preventDefault-v1_2-2538.patch

[Triage Comment]
Carrying forward r/a=frg

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4b505f0c9199
Prevent repeated handling of drop event. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/617a64886fc9c6f56f67248a3508da0c65b5f687
Prevent repeated handling of drop event. r=frg a=frg