1712017 - Menu bar inaccessible in pop-up windows

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Thomas Arnett]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Click a link that opens a pop-up window. Press Alt.

Actual results:

The menu bar is not displayed.

Expected results:

When "Menu Bar" is enabled in the toolbar context menu, the menu bar should be displayed when the window opens. When disabled, the menu bar should be displayed after pressing Alt.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Menus' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

(In reply to Thomas Arnett from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Click a link that opens a pop-up window. Press Alt.

Can you provide a link to a test site where you see this problem? Also, can you clarify how you determined this regressed with bug 1507375?

Comment 3

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Hi,
I am able to reproduce the issue in release 88, beta 89.0b14 and latest nightly 90.0a1 (2021-05-21) using Windows 10, but I am not sure if this an issue or this is the expected behavior. I also tried an old Fx 74, before the bug 1507375 fix and the behavior is the same, the Menu Bar is not displayed in the pop-up window even if the Menu Bar option is checked/enabled.

Thanks for your input.

Comment 4

[Alin Ilea, Desktop Test Engineering]

Attachment: 2021-05-21_13h02_09.mp4

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hi Thomas, we're still waiting to hear back from you (see comment 2). Any updates here?

Comment 6

[Thomas Arnett]

(In reply to :Gijs (out; back Jun 21; he/him) from comment #2)

Can you provide a link to a test site where you see this problem?

The page where I noticed the problem requires an account. Comment 4 shows how to reproduce it with Reddit.

Also, can you clarify how you determined this regressed with bug 1507375?

This used to be controlled by dom.disable_window_open_feature.menubar. The comments on bug 1507375 indicate that the dom.disable_window_open_feature settings were removed for that bug, and the related bugs document related regressions. I subsequently found Firefox 76 was affected but Firefox 75 was not, matching the tracking flags for that bug.

Comment 7

[:Gijs (he/him)]

Arai, can you take a look based on comment #6?

Comment 8

[Tooru Fujisawa [:arai]]

Yes, dom.disable_window_open_feature setting were removed because they were for the old behavior that had been allowing websites to control each UI parts visibility separately.

The better solution here (and for other bugs) would be to provide an option in about:preferences that controls whether to open popup or normal window (either tab or new window) when a website requests opening a popup window.

Currently I'm working standardizing "request opening a popup window" part.
After that, I'll work on adding the option, given the spec will mention about such cusotmizability.

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia)]

:arai: can you please help setting the issue type and severity of this ticket? I'm tending towards "enhancement" and S3.

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia)]

:arai: thanks.