1712138 - Basic Implementation of Class Static Blocks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Basic Implementation of class static blocks

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1712138 - Add option for class-static blocks r?arai

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1712138 - Initial implementation of class-static-fields proposal. r?arai

Reflect.parse will MOZ_CRASH in this patch, but the implementation arrives
in the next.

Depends on D115627

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1712138 - Implement Reflect.parse for static class blocks r?arai

Depends on D115628

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

There's still an unresolved GitHub issue that may require more work on these patches: https://github.com/tc39/proposal-class-static-block/issues/43

I also haven't yet tested against the in-flight test cases in https://github.com/tc39/test262/pull/2968

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Ok, now I have run the tests. Failed 3/29 tests:

test262/prs/2968/language/expressions/object/identifier-shorthand-static-init-await-invalid.js
test262/prs/2968/language/identifier-resolution/static-init-invalid-await.js
test262/prs/2968/language/statements/class/static-init-await-binding-invalid.js

Investigating now :)

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

All of them are related to the complications around await handling. fixing these may best be handled as a followup once that's more resolved.

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1712138 - Handle class-static await early error semantics r?arai

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/858b9355518c
Add option for class-static blocks r=arai
https://hg.mozilla.org/integration/autoland/rev/af05724a3efa
Initial implementation of class-static-fields proposal. r=arai
https://hg.mozilla.org/integration/autoland/rev/22433f887b2f
Implement Reflect.parse for static class blocks r=arai

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/858b9355518c
https://hg.mozilla.org/mozilla-central/rev/af05724a3efa
https://hg.mozilla.org/mozilla-central/rev/22433f887b2f