1712211 - Strict prototype error when trying to compile nss code that includes blapi.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Robert Relyea]

A number of applications build using NSS public headers. Those application often build with --strict-prototypes in the command line, which requires void functions to have the explicit 'void' in the function prototype: example:
foo(void) --- good
foo() --- bad

We recently added a function to a public header that didn't have a void and had to go back and fix it after we released NSS. To prevent this, we added tests to our downstream test suite to make sure that all the public headers pass --strict-prototypes. We found that there is one function prototype in blapi.h ( BLAKE2B_NewContext()) that doesn't pass, so for consistency we should fix that prototype.

Comment 1

[Robert Relyea]

Attachment: Bug 1712211 Strict prototype error when trying to compile nss code that includes blapi.h

in blapi.h, strict prototypes compiles fail on:
extern BLAKE2BContext *BLAKE2B_NewContext();

This patch fixes that problem.

Comment 2

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/207465bda46a4d6eb07ddef2a3a8232643ff027e