Closed Bug 1712212 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29065 - [LayoutNG] Multicol writeback to legacy layout

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29065 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29065
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Multicol writeback to legacy layout

In the case of external/wpt/css/css-multicol/multicol-span-all-016.html,
one column set is created before the spanner, but no column set is
created after the spanner. In NG, columns with content may be created
after the spanner, resulting in incorrect bounds when querying
legacy layout. To fix this, extend the last column set when building up
the flow thread in NGBlockNode::PlaceChildrenInFlowThread() to
encompass any content after the spanner.

Bug: 1210287
Change-Id: I7604de3645fb8874d4faf193614b5742dc64e17e

Reviewed-on: https://chromium-review.googlesource.com/2898491
WPT-Export-Revision: ec070452447f5eee328d81343981f5282b5515a2

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa505548deae
[wpt PR 29065] - [LayoutNG] Writeback to legacy layout with no column set after spanner, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01007b777a46
[wpt PR 29065] - [LayoutNG] Writeback to legacy layout with no column set after spanner, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad1a21af6802
[wpt PR 29065] - [LayoutNG] Writeback to legacy layout with no column set after spanner, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ad1a21af6802

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.