1712346 - Store GMP thread in ChromiumCDMParent and assert methods run on it

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Media code widely uses the convention of MOZ_ASSERTing the thread we expect to be on at the start of functions and methods. This serves the dual purpose of enforcing invariants and documenting the threading model. ChromiumCDMParent always expects to run on the GMP thread of the content process, but doesn't have asserts enforcing this.

While ChromiumCDMParent doesn't need to hold a reference to the GMP thread, I think it would be valuable to do so, perhaps as a debug only member. Then we can use asserts to enforce and document. IMO the benefits of documenting the model are worth some extra (debug only) code.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1712346 - Use MOZ_ASSERT to enforce and document ChromiumCDMParent threading model. r?alwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6e9f5b16b9f
Use MOZ_ASSERT to enforce and document ChromiumCDMParent threading model. r=alwu

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e6e9f5b16b9f