1712379 - sTreatMouseAsTouch needs to be initialized lazily

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[[ex-Mozilla] Agi Sferro | :agi]

We call initMouseAsTouch when creating GeckoSession, normally this happens after a GeckoRuntime has been created so GeckoAppShell.getApplicationContext() will return a non-null value, but if the GeckoSession is created before then, that method will return null causing a NullPointerException (a AC unit test does that).

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1712379 - Initialize sTreatMouseAsTouch lazily.

We call initMouseAsTouch when creating GeckoSession, normally this happens
after a GeckoRuntime has been created, so GeckoAppShell.getApplicationContext()
will return a non-null value.

If the GeckoSession is created before then, however, that method will return
null causing a NullPointerException (a AC unit test does that).

We fix this problem by initializing sTreatMouseAsTouch lazily, and not assuming
that the Context is present.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b5575ecba379
Initialize sTreatMouseAsTouch lazily. r=owlish, a=RyanVM