1712574 - "Already started legacy listener for document-event" console spam

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Dave Townsend [:mossop]]

When I open the browser console I see a whole load of Already started legacy listener for document-event on ... messages completely hiding any messages that might be of interest to me. These should not be showing up.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Oh sorry, I probably introduced these messages via https://phabricator.services.mozilla.com/D114414

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1712574 - Avoid trying to register the legacy listener twice.

This code calling watchResourcesForTarget should only be called when
we already called TargetCommand.watchTargets().
When we call ResourceCommand.watchResources for the first time, watchTargets
will process already existing targets and call ResourceCommand.onTargetAvailable (which calls watchResourcesForTarget).
But for any subsequent call, we should use TargetCommand.getAllTargets and call watchResourcesForTarget manually.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ced00f74c8a2
Avoid trying to register the legacy listener twice. r=jdescottes

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ced00f74c8a2