Closed
Bug 1712591
Opened 4 years ago
Closed 4 years ago
Stop listening to "navigate" from the web console
Categories
(DevTools :: Console, enhancement)
DevTools
Console
Tracking
(Fission Milestone:M8, firefox91 fixed)
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(2 files)
We still listen to target's navigate event in the console codebase, mostly to implement the "warn about replaced console api" and to emit the "reloaded" event:
https://searchfox.org/mozilla-central/source/devtools/client/webconsole/webconsole-ui.js#672-681
Unfortunately, navigate isn't reliable in case of target switch. We should instead listen to DOCUMENT_EVENT's dom-complete.
|
Assignee | |
Updated•4 years ago
|
Whiteboard: dt-fission-m3-triage
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Fission Milestone: --- → M8
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
|
||
Updated•4 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67cc0388af89
[devtools] Expose hasNativeConsoleAPI via DOCUMENT_EVENT's dom-complete resource. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/06d641b3e101
[devtools] Migrate from navigate to DOCUMENT_EVENT dom-complete in the web console. r=nchevobbe
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/67cc0388af89
https://hg.mozilla.org/mozilla-central/rev/06d641b3e101
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•