1712598 - Let AudioDecoderInputTrack fill silence to the output if we write less frames than expectation

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P3)

Description

[Alastor Wu [:alwu]]

Fork from this.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1712598 - part1 : fill silence if detecting a gap in audio.

If there is a gap bewteen the audio that is going to be appended next and the amount of frames that we've appended, then we need to fill silence data in order to keep A/V sync correct.

We did that for the DecodedStream [1] before, but that got removed during the refactoring.

[1] https://searchfox.org/mozilla-central/rev/36181d2c169bafd5e13c534851c8b25d1567cfc3/dom/media/mediasink/DecodedStream.cpp#660-667

Depends on D115749

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1712598 - part2 : add a test for A/V sync.

Depends on D115857

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49489b3d5a3e
part1 : fill silence if detecting a gap in audio. r=padenot
https://hg.mozilla.org/integration/autoland/rev/97a63d63d219
part2 : add a test for A/V sync. r=padenot

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/49489b3d5a3e
https://hg.mozilla.org/mozilla-central/rev/97a63d63d219