Closed Bug 1712613 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29093 - [baselines] Fix synthesising vertical baselines for flex.

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29093 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29093
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[baselines] Fix synthesising vertical baselines for flex.

Previously we always synthesized baselines (outsize an inline formatting
context) using the block-end edge.

This changes the behaviour to use the middle if in a vertical writing
mode. This isn't "complete" as it is still missing the text-orientation
logic, but significantly better.

Bug: 1076080
Change-Id: I14f5aea5adb4f3afcd9194b6f4f9b54addeb54ea

Reviewed-on: https://chromium-review.googlesource.com/2905738
WPT-Export-Revision: 49b8084a426cd397ec2c5bf8d51aea2f4462d8b5

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f3699b0f4c1 [wpt PR 29093] - [baselines] Fix synthesising vertical baselines for flex., a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90d2e88df00a [wpt PR 29093] - [baselines] Fix synthesising vertical baselines for flex., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5f0b6644672 [wpt PR 29093] - [baselines] Fix synthesising vertical baselines for flex., a=testonly

https://hg.mozilla.org/mozilla-central/rev/c5f0b6644672

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.