1712652 - Intermittent Fission service-workers/service-worker/update-module-request-mode.https.html | headers of a main module script

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P5)

Description

[Chris Peterson [:cpeterson]]

service-workers/service-worker/update-module-request-mode.https.html
headers of a main module script

https://searchfox.org/mozilla-central/rev/16388511162ac6bbf5399e69e500e174a2f3972c/testing/web-platform/meta/service-workers/service-worker/update-module-request-mode.https.html.ini#5

[update-module-request-mode.https.html]
  [headers of a main module script]
    expected:
      if release_or_beta: FAIL
      if fission and (os == "linux") and not debug and webrender: ["PASS", "FAIL"]

Comment 1

[Chris Peterson [:cpeterson]]

Niklas, this WPT test depends on Sec-Fetch. The test intermittently fails with Fission is enabled. Do you think fixing this intermittent test failure should block shipping Fission?

The Fission team plans to start a slow rollout of Fission to the Release channel in Q3.

Comment 2

[Chris Peterson [:cpeterson]]

 if fission and (os == "linux") and not debug and webrender: ["PASS", "FAIL"]

This is probably a race condition if the failure only affects opt Linux, so it probably doesn't need to block Fission MVP.

Comment 3

[Niklas]

Do you have a link to a log file where this test failed? I am wondering when this failed the last time.
This test was updated here to have a longer timeout (sometime mid. April). This reminds of a different intermittent failure where such an update fixed the issue.

I have not had to close of a look but since this is only happening on opt linux like you said, I don't think this should block fission.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Niklas from comment #3)

Do you have a link to a log file where this test failed? I am wondering when this failed the last time.
This test was updated here to have a longer timeout (sometime mid. April). This reminds of a different intermittent failure where such an update fixed the issue.

Good question! The if fission and (os == "linux") and not debug and webrender: ["PASS", "FAIL"] annotation was added in wpt-sync bug 1711863 on May 20:

https://searchfox.org/mozilla-central/diff/1cadb2d5566c9e5124c3a116826d61e625ca866b/testing/web-platform/meta/service-workers/service-worker/update-module-request-mode.https.html.ini#5

So this test appears to have failed when importing a new WPT snapshot in May after the test timeout was increased in April. I don't know if this test has failed more recently, but now that we have this bug filed, we might get some comments here from the Intermittent Failures Robot.

I have not had to close of a look but since this is only happening on opt linux like you said, I don't think this should block fission.

SGTM. I set this bug's Fission Milestone to "Future", meaning it doesn't need to block shipping Fission MVP.

Comment 5

[Niklas]

Attachment: Bug 1712652: Expect service-workers/service-worker/update-module-request-mode.https.html to pass. r=ckerschb

Comment 6

[Intermittent Failures Robot]

1 failures in 3502 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1712652&startday=2021-06-07&endday=2021-06-13&tree=all

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ngogge, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #7)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.

Just pushed that to Lando-land :-)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/003db85b60d0
Expect service-workers/service-worker/update-module-request-mode.https.html to pass. r=ckerschb,jgraham

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/003db85b60d0