Error handling for args in GRE installer is non-existent

RESOLVED WONTFIX

Status

Core Graveyard
Installer: GRE
P2
critical
RESOLVED WONTFIX
16 years ago
7 years ago

People

(Reporter: Charles Rosendahl, Assigned: Sean Su)

Tracking

({topembed+})

Trunk
mozilla1.4alpha
x86
Windows 2000
topembed+

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
The GRE installer still succeeds to install even when unknown arguments are
passed to the installer from the command line.

Expected results:  A failure return code.  Possibly a corresponding error string
that maps to the return code.

Example:
gre-win32-installer /ms /app_id "x" /app_path "x.exe"
- should fail as app_id is not a valid argument.

Updated

16 years ago
Status: NEW → ASSIGNED

Comment 1

16 years ago
In addition to deciding what to do with undefined command-line parameters--I'm
positive we really want to fail the entire install in every case, although maybe
we do--we also need to do some validation on the values associated with the
parameters.  For example, "x.exe" also doesn't look to me like a valid path. 
Where is x.exe located?  So, first step in addressing this bug is going to be to
define what cases we do want to address and the desired behavior for each. 
(Reporter)

Comment 2

16 years ago
Nominated
Keywords: nsbeta1
(Reporter)

Updated

16 years ago
Keywords: topembed

Updated

16 years ago
Keywords: topembed → topembed+

Comment 3

16 years ago
One case to handle:  For a shared install (i.e. Shared Installation=TRUE in
uninstall.ini), the /ua command-line option is required.
(Assignee)

Comment 4

16 years ago
over to me.  
Assignee: curt → ssu
Status: ASSIGNED → NEW

Updated

16 years ago
Blocks: 186291
(Assignee)

Comment 5

16 years ago
I don't see a 1.3 final, so 1.4alpha is it.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4alpha
(Reporter)

Comment 6

15 years ago
Another major issue related to installer/uninstaller that really should be fixed
before shipping a GRE based product.

In general, the installer is a deliverable that should enforce the options that
it provides.  To simply say 'here are the options, now please enter garbage' is
not the functionality that we want to ship out the door - it is indicative of a
low quality product.

Severity: normal → critical
Priority: -- → P2
Summary: Bad arguments/params are ignored by GRE installer → Error handling for args in GRE installer is non-existent

Comment 7

15 years ago
adt: nsbeta1-
Keywords: nsbeta1 → nsbeta1-
Product: Core → Core Graveyard
The GRE installer is long dead
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.