171269 - Error handling for args in GRE installer is non-existent

Status: RESOLVED WONTFIX

(Core Graveyard :: Installer: GRE, defect, P2)

Description

[Charles Rosendahl]

The GRE installer still succeeds to install even when unknown arguments are
passed to the installer from the command line.

Expected results:  A failure return code.  Possibly a corresponding error string
that maps to the return code.

Example:
gre-win32-installer /ms /app_id "x" /app_path "x.exe"
- should fail as app_id is not a valid argument.

Comment 1

[Curt Patrick (gone)]

In addition to deciding what to do with undefined command-line parameters--I'm
positive we really want to fail the entire install in every case, although maybe
we do--we also need to do some validation on the values associated with the
parameters.  For example, "x.exe" also doesn't look to me like a valid path. 
Where is x.exe located?  So, first step in addressing this bug is going to be to
define what cases we do want to address and the desired behavior for each. 

Comment 2

[Charles Rosendahl]

Nominated

Comment 3

[Curt Patrick (gone)]

One case to handle:  For a shared install (i.e. Shared Installation=TRUE in
uninstall.ini), the /ua command-line option is required.

Comment 4

[Sean Su]

over to me.  

Comment 5

[Sean Su]

I don't see a 1.3 final, so 1.4alpha is it.

Comment 6

[Charles Rosendahl]

Another major issue related to installer/uninstaller that really should be fixed
before shipping a GRE based product.

In general, the installer is a deliverable that should enforce the options that
it provides.  To simply say 'here are the options, now please enter garbage' is
not the functionality that we want to ship out the door - it is indicative of a
low quality product.

Comment 7

[Samir Gehani]

adt: nsbeta1-

Comment 8

[Daniel Veditz [:dveditz]]

The GRE installer is long dead