The GRE installer still succeeds to install even when unknown arguments are passed to the installer from the command line. Expected results: A failure return code. Possibly a corresponding error string that maps to the return code. Example: gre-win32-installer /ms /app_id "x" /app_path "x.exe" - should fail as app_id is not a valid argument.
In addition to deciding what to do with undefined command-line parameters--I'm positive we really want to fail the entire install in every case, although maybe we do--we also need to do some validation on the values associated with the parameters. For example, "x.exe" also doesn't look to me like a valid path. Where is x.exe located? So, first step in addressing this bug is going to be to define what cases we do want to address and the desired behavior for each.
One case to handle: For a shared install (i.e. Shared Installation=TRUE in uninstall.ini), the /ua command-line option is required.
over to me.
Assignee: curt → ssu
Status: ASSIGNED → NEW
I don't see a 1.3 final, so 1.4alpha is it.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4alpha
Another major issue related to installer/uninstaller that really should be fixed before shipping a GRE based product. In general, the installer is a deliverable that should enforce the options that it provides. To simply say 'here are the options, now please enter garbage' is not the functionality that we want to ship out the door - it is indicative of a low quality product.
Severity: normal → critical
Priority: -- → P2
Summary: Bad arguments/params are ignored by GRE installer → Error handling for args in GRE installer is non-existent
Keywords: nsbeta1 → nsbeta1-
The GRE installer is long dead
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.