Closed Bug 1712695 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29099 - Use PostLayoutBoxFragment() in RecalcChildLayoutOverflow()

Categories

(Core :: Layout: Tables, task, P4)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29099 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29099
Details from upstream follow.

b'Manuel Rego Casasnovas <rego@igalia.com>' wrote:

Use PostLayoutBoxFragment() in RecalcChildLayoutOverflow()

Use PostLayoutBoxFragment() instead of BoxFragment()
in LayoutNGMixin::RecalcChildLayoutOverflow() to avoid hitting
the assert in NGPhysicalBoxFragment::OwnerLayoutBox().

This avoids the DCHECK failures when for some reason
the fragment tree is out of sync.

BUG=1203387
TEST=external/wpt/css/css-tables/crashtests/vertical_percentage_crash.html

Change-Id: I957a7b35df4f0179bc8c3d33d2476b86a34a225b
Reviewed-on: https://chromium-review.googlesource.com/2914881
WPT-Export-Revision: 02e82a8d9c4a04145d6d8861c31ae0c4df53333a

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44e6135d63d9
[wpt PR 29099] - Use PostLayoutBoxFragment() in RecalcChildLayoutOverflow(), a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1423eaf5cc0d
[wpt PR 29099] - Use PostLayoutBoxFragment() in RecalcChildLayoutOverflow(), a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5f310434540
[wpt PR 29099] - Use PostLayoutBoxFragment() in RecalcChildLayoutOverflow(), a=testonly

https://hg.mozilla.org/mozilla-central/rev/e5f310434540

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.