1712724 - Adding @ to any text on the Firefox Sync login page will automatically select the entire text

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2021-05-25_15h27_00.mp4

[Affected platforms]:
Platforms: Windows, Mac, Ubuntu

[Steps to reproduce]

1. Launch the Firefox browser and reach the Firefox SYNC Sign in page.
2. Add any text and then insert an @.

[Expected result]
The user should be able to add any characters without issues.

[Actual result]
Adding the @ character will select the entire text.
Clicking inside the field after adding the @ character and then deleting the @ character again will highlight the entire remaining text.

Comment 1

[Rares Doghi, Desktop QA]

I will try to get a regression range for this issue as soon as possible.

Comment 2

[Rares Doghi, Desktop QA]

Found the issue that regressed it : Bug 1711057 seems to be the culprit.

Comment 3

[Rares Doghi, Desktop QA]

Emilio can you please take a look at this issue?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1712724 - Cleanup focus method mask usage. r=edgar,smaug

No behavior change, but this makes the next patch more straight-forward.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1712724 - Don't trigger select on programmatic focus during keyboard events. r=smaug

Depends on D115900

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36504d508b34
Cleanup focus method mask usage. r=smaug
https://hg.mozilla.org/integration/autoland/rev/46b1d60b6b6b
Don't trigger select on programmatic focus during keyboard events. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29111 for changes under testing/web-platform/tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61d8ca98120b
Fix test_focus.xhtml to account for the new flag.

Comment 9

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1712724) for causing mochitests without e10s failures in test_focus.xhtml
Backout link: https://hg.mozilla.org/integration/autoland/rev/0b451a88f161548a6244a3f34e3bed1780dfdb71
Push with failures, failure log.

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b439a624f195
Cleanup focus method mask usage. r=smaug
https://hg.mozilla.org/integration/autoland/rev/fab0c2183cfb
Don't trigger select on programmatic focus during keyboard events. r=smaug

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b439a624f195
https://hg.mozilla.org/mozilla-central/rev/fab0c2183cfb

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot