1712737 - Messages and errors from previous window globals may be notified twice

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

When enabling server side target switching (devtools.target-switching.server.enabled = true), we do create one target actor per WindowGlobal.
By doing so, we end up creating resource watchers for each WindowGlobal.

These console watchers will fetch errors and messages from platform cache:
https://searchfox.org/mozilla-central/source/devtools/server/actors/resources/utils/nsi-console-listener-watcher.js#55,62
This cache contains all errors and messages coming from any document running in the current process. So that it will typically contain messages from the previous WindowGlobal...
And as the code filtering out the messages currently filter out by browserId:
https://searchfox.org/mozilla-central/source/devtools/server/actors/resources/error-messages.js#84
We end up notifying about the previous WindowGlobal messages twice.
If persist is ON we will notify about all previous document messages twice,
if persist if OFF, we will see previous document messages in addition to the new document ones.

devtools/client/framework/test/browser_toolbox_error_count_reset_on_navigation.js is failing with devtools.target-switching.server.enabled = true because of that.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1712737 - Filter error messages by inner Window ID

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1712737 - [devtools] Filter nsiConsole messages by their innerWindowID. r=ochameau.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e11836c2c03d
[devtools] Filter nsiConsole messages by their innerWindowID. r=ochameau.

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e11836c2c03d