Closed Bug 1712770 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29104 - Forced accent-color followup

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29104 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29104
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

Forced accent-color followup

In CL:2847031, accent-color was forced to auto in forced colors mode.
This CL moves this logic to StyleAdjuster::AdjustForForcedColorsMode()
so that it is forced in the same place as the other properties forced
at computed value time.

Bug: 1092093
Change-Id: I77ba92e30c6ea060521a8d05747c32a38f149601
Reviewed-on: https://chromium-review.googlesource.com/2909975
WPT-Export-Revision: 2481694d6cbc97cec0c1927740bff62c4a5d318e

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/forced-colors-mode/forced-colors-mode-50.html
Accent-color computes to auto in forced colors mode, unless forced-color-adjust is none.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/10f8a4117201 [wpt PR 29104] - Forced accent-color followup, a=testonly https://hg.mozilla.org/integration/autoland/rev/7cbc33777860 [wpt PR 29104] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9e3b9701014 [wpt PR 29104] - Forced accent-color followup, a=testonly https://hg.mozilla.org/integration/autoland/rev/ceab07d891e2 [wpt PR 29104] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d81448ae6174 [wpt PR 29104] - Forced accent-color followup, a=testonly https://hg.mozilla.org/integration/autoland/rev/ae3c6f3de19a [wpt PR 29104] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d81448ae6174
https://hg.mozilla.org/mozilla-central/rev/ae3c6f3de19a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.