Closed Bug 1712814 Opened 3 years ago Closed 2 years ago

High frequency browser/components/places/tests/browser/browser_bookmark_popup.js | Test timed out -

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1775659

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regressed 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [stockwell disabled])

Attachments

(2 files)

Bug 1712814 - disable browser_bookmark_popup.js on Linux_tsan for frequent failures. r=#intermittent-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1712814 - skip browser_bookmark_popup.js on Linux ASan. r=mak DONTBUILD
48 bytes, text/x-phabricator-request
Details | Review

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=340759052&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VT4DDENBSRm7M0kIzp7NpA/runs/0/artifacts/public/logs/live_backing.log

[task 2021-05-25T18:15:15.947Z] 18:15:15     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_popup.js | remove/cancel button label should match isEditingBookmark state - "bookmark-panel-cancel" == "bookmark-panel-cancel" - 
[task 2021-05-25T18:15:15.947Z] 18:15:15     INFO - Buffered messages finished
[task 2021-05-25T18:15:15.948Z] 18:15:15     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_popup.js | Test timed out - 
[task 2021-05-25T18:15:15.948Z] 18:15:15     INFO - GECKO(1583) | MEMORY STAT | vsize 130551606MB | residentFast 2238MB
[task 2021-05-25T18:15:15.949Z] 18:15:15     INFO - TEST-OK | browser/components/places/tests/browser/browser_bookmark_popup.js | took 120051ms
[task 2021-05-25T18:15:15.949Z] 18:15:15     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-05-25T18:15:15.950Z] 18:15:15     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_popup.js | Found a tab after previous test timed out: data:text/html,<html><body></body></html> - 
[task 2021-05-25T18:15:15.950Z] 18:15:15     INFO - checking window state
[task 2021-05-25T18:15:16.087Z] 18:15:16     INFO - TEST-START | browser/components/places/tests/browser/browser_bookmark_private_window.js
[task 2021-05-25T18:17:16.142Z] 18:17:16     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-05-25T18:17:16.142Z] 18:17:16     INFO - Buffered messages logged at 18:15:16
[task 2021-05-25T18:17:16.142Z] 18:17:16     INFO - Entering test bound test_add_bookmark_from_private_window
[task 2021-05-25T18:17:16.143Z] 18:17:16     INFO - Buffered messages finished
[task 2021-05-25T18:17:16.143Z] 18:17:16     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_private_window.js | Test timed out - 
[task 2021-05-25T18:17:16.249Z] 18:17:16     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-05-25T18:17:16.250Z] 18:17:16     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_popup.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_popup.js:150 - TypeError: can't access property "equal", Assert is null
[task 2021-05-25T18:17:16.250Z] 18:17:16     INFO - Stack trace:
[task 2021-05-25T18:17:16.251Z] 18:17:16     INFO - test_bookmarks_popup/<@chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_popup.js:150:7
[task 2021-05-25T18:17:16.816Z] 18:17:16     INFO - GECKO(1583) | MEMORY STAT | vsize 130551620MB | residentFast 2292MB
[task 2021-05-25T18:17:16.817Z] 18:17:16     INFO - TEST-OK | browser/components/places/tests/browser/browser_bookmark_private_window.js | took 120729ms

Seems to be caused by Bug 1711723.
Mark, could you take a look please?
Thank you.

Flags: needinfo?(standard8)
Regressed by: 1711723

My suspicion is that this was actually caused by bug 1711117 (rev).

I'm not quite sure why, but looking back at the history, I think this first showed up when that bug landed. That implies there's potentially some sort of inter-test dependency that isn't always required.

Flags: needinfo?(standard8)
Regressed by: 1711117
No longer regressed by: 1711723
Has Regression Range: --- → yes

This was also failing in https://bugzilla.mozilla.org/show_bug.cgi?id=1695011#c23 alongside other tests. https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2021-05-05&endday=2021-05-12&tree=trunk&bug=1695011

  • browser_bookmarkProperties_folderSelection.js - was fixed in Bug 1695011
  • browser_bookmark_add_tags.js - was disabled in Bug 1711117

browser_bookmark_popup.js is failing next alongside with:

  • browser_bookmark_private_window.js
  • browser_bookmark_remove_tags.js
  • browser_bookmark_titles.js
  • browser_bookmark_remove_tags.js
  • browser_bookmarksProperties.js.

Log with all failing tests: https://treeherder.mozilla.org/logviewer?job_id=340875962&repo=autoland&lineNumber=2632

Assignee: nobody → abutkovits
Status: NEW → ASSIGNED

I've just had a chat with Marco, and we'll go with disabling for now, since we don't know what the issue is. We suspect some of the tests in comment 4 might also need disabling, but we would like to only disable them if necessary - these could be tests failing because a previous one has failed.

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ff8917c0ae0 disable browser_bookmark_popup.js on Linux_tsan for frequent failures. r=Standard8
See Also: → 1713510
Assignee: abutkovits → nobody
Status: ASSIGNED → NEW
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

There have been a total of 94 failures in the last 7 days, all on linux1804-64-asan-qr opt

Recent failure log

[task 2021-08-02T09:38:43.216Z] 09:38:43     INFO - Buffered messages finished
[task 2021-08-02T09:38:43.217Z] 09:38:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_popup.js | Test timed out - 
[task 2021-08-02T09:38:43.219Z] 09:38:43     INFO - GECKO(2543) | MEMORY STAT | vsize 20975827MB | residentFast 1606MB
[task 2021-08-02T09:38:43.220Z] 09:38:43     INFO - TEST-OK | browser/components/places/tests/browser/browser_bookmark_popup.js | took 90027ms
[task 2021-08-02T09:38:43.221Z] 09:38:43     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-08-02T09:38:43.223Z] 09:38:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_popup.js | Found a tab after previous test timed out: data:text/html,<html><body></body></html> - 
[task 2021-08-02T09:38:43.224Z] 09:38:43     INFO - checking window state
[task 2021-08-02T09:38:43.225Z] 09:38:43     INFO - TEST-START | browser/components/places/tests/browser/browser_bookmark_private_window.js```

Marco, can you take a look at this frequent failure? It got frequent on July 28/29.

Severity: S4 → --
Flags: needinfo?(mak)
Priority: P5 → --

I'll be away for 2 weeks, thus I don't think I can look at it very soon.

Got frequent for unknown reason. Disable until a person has time to investigate.

Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/5c16c2d10504 skip browser_bookmark_popup.js on Linux ASan. r=mak DONTBUILD

It's unclear why this is timing out, but recently some bugs have been filed about unexpected behaviors when the bookmarks dialogs are closed (bug 1718982 for example), so there could be a relation. with the disabling the ratio is low and hopefully those bugs can be addressed.

Flags: needinfo?(mak)

Changing severity to S3 because of reasons for this are unclear, it should be investigated but for now it has been disabled on platforms where it's happening more often.

Severity: -- → S3
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: