1712954 - Permanent image/test/fuzzing/TestDecoders.cpp:132:12: error: unused function 'RunDecodeToSurfaceFuzzingJXL' [-Werror,-Wunused-function] when Gecko 90 merges to Beta on 2021-05-31

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-05-26T12:42:44.918Z] 12:42:44 ERROR - /builds/worker/checkouts/gecko/image/test/fuzzing/TestDecoders.cpp:132:12: error: unused function 'RunDecodeToSurfaceFuzzingJXL' [-Werror,-Wunused-function]
[task 2021-05-26T12:42:44.918Z] 12:42:44 INFO - static int RunDecodeToSurfaceFuzzingJXL(nsCOMPtr<nsIInputStream> inputStream) {
[task 2021-05-26T12:42:44.918Z] 12:42:44 INFO - ^

The definition needs to be #ifdef MOZ_JXL like its caller.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1712954 - Only include RunDecodeToSurfaceFuzzingJXL if JXL built. r=saschanaz

Bug 1712147 restricted JPEG-XL (controlled by preference image.jxl.enabled) to be only true
if MOZ_JXL is set and ifdef-ed the caller. This patch ifdef-s the function definition.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0e512875bf0
Only include RunDecodeToSurfaceFuzzingJXL if JXL built. r=tnikkel DONTBUILD

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Thanks!

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a0e512875bf0

Comment 5

[Iulian Moraru]

Verified fixed with today's central-as-beta simulation