1712963 - Refactor mValid checks in WebGPU for early-out

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P3)

Description

[Dzmitry Malyshau [:kvark]]

Requested in https://phabricator.services.mozilla.com/D114878#inline-643161
In code like this:

if (mValid) {
    ffi::wgpu_render_bundle_draw(mEncoder, aVertexCount, aInstanceCount,
                                 aFirstVertex, aFirstInstance);
  }

The suggestion is to d oif (!mValid) { ... return; } instead.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1712963: Simplify mValid handling in some WebGPU classes.

Primarily this standardizes ComputePassEncoder, RenderBundleEncoder and
RenderPassEncoder on the "if (!mValid)" pattern for early exits for ffi
functions. It also attempts to make each class have at most two ways to
become invalid:

1. RenderBundleEncoder and RenderPassEncoder can become invalid at
   construction time.
2. Those classes and ComputePassEncoder all now have an implementation
   of their ::Cleanup method, which is called from the destructor, and the
   Cleanup method is responsible for making the object invalid and
   releasing internal resources (possibly by calling another method).

Together these changes make it easier to reason about what mValid means
for these classes, and what is the state of their internal resources.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e98d0558c0bf
Simplify mValid handling in some WebGPU classes. r=webgpu-reviewers,nical

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e98d0558c0bf