1713081 - wasi support part 16: fix build system to be able to use clang-12 provided by mozilla

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Comment 1

[Dmitry Bezhetskov]

Attachment: Bug 1713081 - Adjust the build system to use the internal clang-12 to compile SM to wasm. r=jandem

1. Remove the rpath-link linker flag because wasm-ld doesn't support it.
2. Add <unistd.h> because implicit declaration of function {lseek, read, write} is invalid in C99`.
3. Ifdef tzset because wasi doesn't support it.
4. Enable single thread model for cxx compiler to prevent defining STD_THREADS in advance and allow wasi to define LIBCPP_HAS_NO_THREADS because wasi doesn't support threads yet.
5. Adjust some new tests because WASI doesn't support Intl, SharedArrayBuffer and to many recursion calls.

Comment 2

[Dmitry Bezhetskov]

Attachment: Bug 1713081 - Fix tests for wasi. r=jandem

WASI doesn't support tzset() so it's ifdefed.
WASI doesn't support Intl so intl-fallback-original.js is disabled.
WASI doesn't support SharedArrayBuffer so error-messages.js is disabled.
WASI doesn't support too much recursion so bug1710089.js is disabled.

Comment 3

[Dmitry Bezhetskov]

Attachment: Bug 1713081 - Fix to use the default clang from upstream for SM WASI. r=glandium

To compile SM to .wasm we need to use clang from wasi-sdk, this patch
allows us to use default clang-12 from mozilla's repo.
We remove usage of rpath-link flag because wasm-ld doesn't support it,
enable single thread model because wasi is single threaded
and finally add <unistd.h> becase it is forbidden to use read/write/lseek
without this header.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d83cd7ab5ca
Fix tests for wasi. r=jandem

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1d83cd7ab5ca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa1a8a489ee2
Fix to use the default clang from upstream for SM WASI. r=glandium

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fa1a8a489ee2