Please do not re-use accelerator keys in popup alerts
Categories
(Toolkit :: Application Update, enhancement, P5)
Tracking
()
People
(Reporter: TechHorse, Unassigned)
References
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0
Steps to reproduce:
Hello, as a predominantly keyboard user I frequently press alt+D to focus the address bar. Yet at least twice now I have been caught out by the fact that the popup alert for downloading a new version of FF re-uses alt+D for its 'download update now' button.
I think one time I just missed the appearance of this popup while I was typing, and another time I knew it was there but forgot myself and unthinkingly pressed alt+D for the address bar.
There is also scope for accidentally, say, saving a logon you didn't wish to savr, instead you pressed alt+S to access the history menu.
So in a nutshell, please do not re-use in-use accelerator keys in popup alerts. Or at the bare minimum, not alt+D as that is the one I have been most caught out by.
As a secondary suggestion, a unification of the popup alerts into Yes (alt+Y) or No (alt+N) questions would be useful in further mitigating against this problem. As when a question pops up ('do you wish to save this login' / 'do you want to allow this site to access your location' etc) one can just press alt+Y/N without accidentally activating these options when they meant to do something else.
Thanks for reading.
|
||
Comment 1•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Updated•4 years ago
|
This is about the popup alert message boxes. Not sure if there is a component specifically for those?
|
|
||
Comment 3•4 years ago
|
||
Ah, yes, this should be in Messaging System.
|
||
Comment 4•4 years ago
|
||
mhowell, I believe the popup alert in question is the application update notification panel with strings and accesskeys updated in bug 1696054 (although the specific "alt+D" was unchanged in that patch). Is there a better place to triage/track this bug? Technically this panel is not part of the app ::Menu but probably not useful to have in ::General.
|
||
Comment 5•4 years ago
|
||
Ah, yeah, these were always under somewhat ambiguous ownership. They were originally implemented under the Toolkit :: Application Update component, so that's a decent place for this I think; they may disagree over there ;)
I'd also like to solicit suggestions here for an alternate accelerator; I don't think UX would be on board with the idea of changing all the buttons to yes/no, so changing that particular accelerator might be the only way out of this.
The accelerators I am aware of are F E V S B T H for the alt / F10 menu items, and of course D for the address bar.
So how about alt+O for the popup's Download button? Or change it to "Download Update" and have alt+U?
Bit of a shame about the lack of unification as a consistent Y / N hotkey would have saved having to manually navigate to the popups then tabbing to the buttons. But I appreciate that that would be a more involved overhaul! Getting rid of alt+D on the update popup is of course the main request.
|
||
Comment 7•4 years ago
|
||
I also feel like I should note that there are 2 other hotkeys to select the location bar that don't conflict with this: Control+L and F6.
Fair enough but alt+D is a very familiar and universal hotkey that can be hit with one hand, and needs to be pressed only once. The other two might need two hands or multiple presses. I would prefer to keep using it. Although thanks for raising my awareness of one new alternative hotkey (ctrl+L).
Description
•