1713212 - Make mozilla::Unused unused

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Steve Fink [:sfink] [:s:]]

Before [[nodiscard]], you needed to do mozilla::Unused << expr in order to properly mark an expression as unused. Now, we can just cast to (void).

This bug is for removing the deprecated mozilla::Unused and preventing it from being added.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 - Convert uses of mozilla::Unused to void casts in gc/

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 - Convert uses of mozilla::Unused to void casts in vm/

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 - Convert uses of mozilla::Unused to void casts in jit/

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 - Convert uses of mozilla::Unused to void casts in wasm/

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 - Convert uses of mozilla::Unused to void casts in rest of JS code

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 - Add a check to prevent mozilla/Unused.h from being included

Comment 7

[Steve Fink [:sfink] [:s:]]

Whee, I spread out the reviews as a way to make sure people know.

See the thread https://groups.google.com/g/mozilla.dev.platform/c/0ySnEmxh12Y for what's going on here.

Thanks, cpeterson!

Comment 8

[Chris Peterson [:cpeterson]]

Nice! There are still 1000+ uses of Unused << in other directories, but your lint will keep that number from growing. Perhaps someday Unused itself can be removed (bug 1628542).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8a2d8249563
Convert uses of mozilla::Unused to void casts in gc/ r=jonco
https://hg.mozilla.org/integration/autoland/rev/035615e942f1
Convert uses of mozilla::Unused to void casts in vm/ r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/0431e2e3f8f2
Convert uses of mozilla::Unused to void casts in jit/ r=iain
https://hg.mozilla.org/integration/autoland/rev/0f7c74b50763
Convert uses of mozilla::Unused to void casts in wasm/ r=rhunt
https://hg.mozilla.org/integration/autoland/rev/8137e1710fb5
Convert uses of mozilla::Unused to void casts in rest of JS code r=jandem
https://hg.mozilla.org/integration/autoland/rev/eb812224c514
Add a check to prevent mozilla/Unused.h from being included r=mgaudet

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f8a2d8249563
https://hg.mozilla.org/mozilla-central/rev/035615e942f1
https://hg.mozilla.org/mozilla-central/rev/0431e2e3f8f2
https://hg.mozilla.org/mozilla-central/rev/0f7c74b50763
https://hg.mozilla.org/mozilla-central/rev/8137e1710fb5
https://hg.mozilla.org/mozilla-central/rev/eb812224c514

Comment 11

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1713212 followup - switch to DebugOnly<> to follow review comment

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/394f76022d39
followup - switch to DebugOnly<> to follow review comment

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/394f76022d39