1713350 - SVG rendering hangs up in GDocs, causing significant performance issues.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Mike Hoye [:mhoye]]

I'm experiencing a significant perf hit in GDocs, a type-then-wait-for-the letters-to-appear kind of thing. The performance profile is here:

https://share.firefox.dev/2SCxWI9

We are apparently blocking a the responsible thread for 650 of every 700 milliseconds which frankly seems like a lot. Per Slack, https://bugzilla.mozilla.org/show_bug.cgi?id=1704792 may be related.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Does setting image.svg.blob-image to false and restarting help?

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Never mind, I can see it in the trace.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1713350 - Ensure we reset the dirty flag for SVG blob recordings during moves.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f845b3a52e7d
Ensure we reset the dirty flag for SVG blob recordings during moves. r=jrmuizel

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f845b3a52e7d

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Can you retest and confirm it is fixed, or provide a trace if not? Thanks!

Comment 7

[Mike Hoye [:mhoye]]

I have not been able to reproduce this in the last few days, let's call this fixed.

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f845b3a52e7d
Ensure we reset the dirty flag for SVG blob recordings during moves.
r=jrmuizel

== Change summary for alert #30257 (as of Sun, 30 May 2021 19:06:15 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
19%	tart (docs)		macosx1015-64-shippable-qr	e10s stylo webrender-sw	2.58 -> 2.09
17%	tart (docs)		windows10-64-shippable-qr	e10s stylo webrender-sw	3.33 -> 2.77
16%	tart (docs)		macosx1015-64-shippable-qr	e10s stylo webrender	2.53 -> 2.13
16%	tart (docs)		windows10-64-shippable-qr	e10s stylo webrender	3.33 -> 2.81
15%	tart (docs)		macosx1014-64-shippable-qr	e10s stylo webrender	4.98 -> 4.22
7%	tart (docs)		linux1804-64-shippable-qr	e10s stylo webrender	4.10 -> 3.82

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30257