1713486 - [SW-WR] Negative memory reported on https://codepen.io/halvves/pen/qBqvVRO

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Mayank Bansal]

Attachment: memory-report.json.gz

enable sw-wr
Got to https://codepen.io/halvves/pen/qBqvVRO

open about:memory. and check the GPU process

AR: Negative memory numbers reported.
ER: Probably not so

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Our handling of different swgl contexts is broken. We always use the current one when we should be using a given one for a particular renderer.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1713486. Fix per context swgl memory reporting.

This passes the swgl context down from the renderer
instead of using the current context. This ensures
we report all of the contexts and don't double report.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e39147271cc
Fix per context swgl memory reporting. r=lsalzman

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for webrender bustage on webrender\src\device\gl.rs

• backout: https://hg.mozilla.org/integration/autoland/rev/d2681c20c636e9569e4f6024bcce00988ce3b844

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=1e39147271ccdd0cc85218f7293868637d632dc6&searchStr=webrender

• failure log: https://treeherder.mozilla.org/logviewer?job_id=341532246&repo=autoland&lineNumber=323

[task 2021-06-02T12:45:02.424Z]      Running `rustc --crate-name webrender --edition=2018 webrender/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C metadata=8f21443f61821e12 -C extra-filename=-8f21443f61821e12 --out-dir /builds/worker/checkouts/gecko/gfx/wr/target/debug/deps -C incremental=/builds/worker/checkouts/gecko/gfx/wr/target/debug/incremental -L dependency=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps --extern bincode=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libbincode-ac670445540ee3a2.rmeta --extern bitflags=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libbitflags-f95df477f42c8cef.rmeta --extern byteorder=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libbyteorder-d3ceb5724c90c78b.rmeta --extern cstr=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libcstr-6ce02047118d1c9b.so --extern derive_more=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libderive_more-ddbaa11b34297b98.so --extern etagere=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libetagere-147d3cfc2e28c8dd.rmeta --extern euclid=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libeuclid-acea1f258243e04d.rmeta --extern freetype=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libfreetype-46b81667f9479775.rmeta --extern fxhash=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libfxhash-ca46a224e8490b79.rmeta --extern gleam=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libgleam-583a8c0710981e93.rmeta --extern lazy_static=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/liblazy_static-aff2a99d64d111b7.rmeta --extern libc=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/liblibc-14db78252efcdb6f.rmeta --extern log=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/liblog-09c7a42313ad922a.rmeta --extern malloc_size_of_derive=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libmalloc_size_of_derive-901d393a0863be68.so --extern num_traits=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libnum_traits-5cd02c866fda9108.rmeta --extern plane_split=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libplane_split-03dcf2fc4e99ce99.rmeta --extern rayon=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/librayon-a8b32cbf9d342562.rmeta --extern smallvec=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libsmallvec-37aac14711665c82.rmeta --extern svg_fmt=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libsvg_fmt-3511d708e9642806.rmeta --extern time=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libtime-91dc5b837a9b75b7.rmeta --extern tracy_rs=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libtracy_rs-5e72aa9f6c9bead5.rmeta --extern api=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libwebrender_api-eae8a953007be19a.rmeta --extern webrender_build=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libwebrender_build-96f0f59126f855bb.rmeta --extern malloc_size_of=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libwr_malloc_size_of-e3fbfb64be62110a.rmeta --deny warnings`
[task 2021-06-02T12:45:05.719Z] error: unused variable: `swgl`
[task 2021-06-02T12:45:05.719Z]     --> webrender/src/device/gl.rs:3917:65
[task 2021-06-02T12:45:05.719Z]      |
[task 2021-06-02T12:45:05.719Z] 3917 |     pub fn report_memory(&self, size_op_funs: &MallocSizeOfOps, swgl: *mut c_void) -> MemoryReport {
[task 2021-06-02T12:45:05.719Z]      |                                                                 ^^^^ help: if this is intentional, prefix it with an underscore: `_swgl`
[task 2021-06-02T12:45:05.719Z]      |
[task 2021-06-02T12:45:05.719Z]      = note: `-D unused-variables` implied by `-D warnings`
[task 2021-06-02T12:45:05.719Z] 
[task 2021-06-02T12:45:07.539Z] error: aborting due to previous error
[task 2021-06-02T12:45:07.539Z] 
[task 2021-06-02T12:45:07.566Z] error: could not compile `webrender`
[task 2021-06-02T12:45:07.566Z] 
[task 2021-06-02T12:45:07.566Z] Caused by:
[task 2021-06-02T12:45:07.566Z]   process didn't exit successfully: `rustc --crate-name webrender --edition=2018 webrender/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C metadata=8f21443f61821e12 -C extra-filename=-8f21443f61821e12 --out-dir /builds/worker/checkouts/gecko/gfx/wr/target/debug/deps -C incremental=/builds/worker/checkouts/gecko/gfx/wr/target/debug/incremental -L dependency=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps --extern bincode=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libbincode-ac670445540ee3a2.rmeta --extern bitflags=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libbitflags-f95df477f42c8cef.rmeta --extern byteorder=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libbyteorder-d3ceb5724c90c78b.rmeta --extern cstr=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libcstr-6ce02047118d1c9b.so --extern derive_more=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libderive_more-ddbaa11b34297b98.so --extern etagere=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libetagere-147d3cfc2e28c8dd.rmeta --extern euclid=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libeuclid-acea1f258243e04d.rmeta --extern freetype=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libfreetype-46b81667f9479775.rmeta --extern fxhash=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libfxhash-ca46a224e8490b79.rmeta --extern gleam=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libgleam-583a8c0710981e93.rmeta --extern lazy_static=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/liblazy_static-aff2a99d64d111b7.rmeta --extern libc=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/liblibc-14db78252efcdb6f.rmeta --extern log=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/liblog-09c7a42313ad922a.rmeta --extern malloc_size_of_derive=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libmalloc_size_of_derive-901d393a0863be68.so --extern num_traits=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libnum_traits-5cd02c866fda9108.rmeta --extern plane_split=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libplane_split-03dcf2fc4e99ce99.rmeta --extern rayon=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/librayon-a8b32cbf9d342562.rmeta --extern smallvec=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libsmallvec-37aac14711665c82.rmeta --extern svg_fmt=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libsvg_fmt-3511d708e9642806.rmeta --extern time=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libtime-91dc5b837a9b75b7.rmeta --extern tracy_rs=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libtracy_rs-5e72aa9f6c9bead5.rmeta --extern api=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libwebrender_api-eae8a953007be19a.rmeta --extern webrender_build=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libwebrender_build-96f0f59126f855bb.rmeta --extern malloc_size_of=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libwr_malloc_size_of-e3fbfb64be62110a.rmeta --deny warnings` (exit code: 1)
[taskcluster 2021-06-02 12:45:07.899Z] === Task Finished ===
[taskcluster 2021-06-02 12:45:07.899Z] Unsuccessful task run with exit code: 101 completed in 128.919 seconds

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1a5c98250fd
Fix per context swgl memory reporting. r=lsalzman

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d1a5c98250fd