1713520 - gfx/2d/Path.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/gfx/2d/Path.cpp#403-405

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Richal Verma]

Attachment: Bug 1713520 - Remove "else" after "return" in FindInflectionPoints r=sylvestre

Comment 2

[Richal Verma]

Comment on attachment 9224385 [details]
Bug 1713520 - Remove "else" after "return" in FindInflectionPoints r=sylvestre

Hi! I've just implemented the change - I'm still getting the hang of the contribution process so hopefully I've done everything correctly.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:richalverma00, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fec78c0901ac
Remove "else" after "return" in FindInflectionPoints r=nical

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fec78c0901ac