Closed Bug 1713520 Opened 5 months ago Closed 4 months ago

gfx/2d/Path.cpp: do not use 'else' after 'return'

Categories

(Core :: Graphics, task, P3)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: Sylvestre, Assigned: richalverma00, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/gfx/2d/Path.cpp#403-405

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Component: General → Graphics
Product: Toolkit → Core
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → richalverma00
Status: NEW → ASSIGNED

Comment on attachment 9224385 [details]
Bug 1713520 - Remove "else" after "return" in FindInflectionPoints r=sylvestre

Hi! I've just implemented the change - I'm still getting the hang of the contribution process so hopefully I've done everything correctly.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:richalverma00, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(richalverma00)
Flags: needinfo?(nical.bugzilla)
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fec78c0901ac
Remove "else" after "return" in FindInflectionPoints r=nical
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: needinfo?(nical.bugzilla)
You need to log in before you can comment on or make changes to this bug.