Closed Bug 1713524 Opened 4 years ago Closed 4 years ago

netwerk/cache2/CacheFileContextEvictor.cpp: do not use 'else' after 'continue'

Categories

(Core :: Networking: HTTP, task, P5)

task

Tracking

()

RESOLVED DUPLICATE of bug 1714307

People

(Reporter: Sylvestre, Assigned: surajeet310)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++][necko-triaged])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

do not use 'else' after 'continue':
https://searchfox.org/mozilla-central/source/netwerk/cache2/CacheFileContextEvictor.cpp#609-613

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Priority: -- → P5
Whiteboard: [lang=C++] → [lang=C++][necko-triaged]
Assignee: nobody → surajeet310
Status: NEW → ASSIGNED
Attachment #9224415 - Attachment description: Bug 1713524 -Removed 'else' after'continue' .r=Sylvestre → Bug 1713524 - Removed 'else' after 'continue' to simplify the code

This was already fixed in bug 1714307.
Thanks for taking the time to post a patch!

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: