1713545 - RDM with touch events sends SetCapture warning in the console

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Karl Dubost💡 :karlcow]

What were you doing?

1. Open Firefox, activate RDM with a Mobile UA and touch activated.
2. Go to https://www.mozilla.org/en-US/
3. Click on a link.

What happened?

The following message appears in the console.

Element.setCapture() is deprecated. Use Element.setPointerCapture() instead. For more help https://developer.mozilla.org/docs/Web/API/Element/setPointerCapture

What should have happened?

Nothing probably

This refers to
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/devtools/server/actors/emulation/touch-simulator.js#217-219

which is calling

https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/testing/marionette/harness/marionette_harness/www/shim.js#278-288

Anything else we should know?

Probably not urgent.

Comment 2

[Ksenia Berezina [:ksenia]]

We've received a report in https://github.com/webcompat/web-bugs/issues/107300 about this issue. The warning message could be misleading for developers as it makes you believe that the issue is with the actual code and not RDM.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

The message was added in Bug 777972 (see https://hg.mozilla.org/mozilla-central/diff/8b82a374ece51b3d874bbc41db97ef5b2e0c5026/browser/devtools/shared/touch-events.js)

evt.target.setCapture was used to make sure events are not dispatched to something else, for example a different window.
We could replace this with evt.target.setPointerCapture, but there is no test covering this, and trying to make appear an overlapping
element still only dispatch the element to the original target, so we can probably remove this just fine.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1713545 - [devtools] Remove deprecated (and unecessary?) setCapture call in touch simulator. r=#devtools-reviewers.

evt.target.setCapture is deprecated and displays a message to the console.
it was used to make sure events are not dispatched to something else, for
example a different window.
We could replace this with evt.target.setPointerCapture,
but there is no test covering this, and trying to make appear an overlapping
element still only dispatch the element to the original target, so we can
probably remove this just fine.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51420a723cbc
[devtools] Remove deprecated (and unecessary?) setCapture call in touch simulator. r=devtools-reviewers,ochameau.

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/51420a723cbc