1713550 - Include-what-you-use correctness in js/public/GCVector.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Philip Chimento [:ptomato]]

I've heard that it's not really a goal to be able to run include-what-you-use across the whole SpiderMonkey codebase, but I do use it in my codebase that embeds SpiderMonkey.

There are some incorrect #includes in js/public/GCVector.h that trigger a bug in include-what-you-use and I'm hoping it'd be OK to just fix this header to have the proper includes.

If there is interest in using include-what-you-use across the whole SpiderMonkey codebase in the future, I can give some tips or possibly help set that up, but for now I'll just stick to fixing this one file.

Comment 1

[Philip Chimento [:ptomato]]

Attachment: Bug 1713550 - Fix includes in js/public/GCVector.h. r?jandem

https://bugzilla.mozilla.org/show_bug.cgi?id=1713550

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f76f3b0a3c9f
Fix includes in js/public/GCVector.h. r=jandem

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f76f3b0a3c9f (Bug 1713550) for causing bc failures in browser_bookmarksProperties.js.
https://hg.mozilla.org/integration/autoland/rev/06d7dd6626e0e75d6fbfae46be23d9e325524a16

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f76f3b0a3c9f2b5a2f19ce82bae051fb6a7564ea&selectedTaskRun=JWsnJ5CfTG2qvTtC2n0c-w.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=341255431&repo=autoland&lineNumber=3050

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e79ef9f3dae
Fix includes in js/public/GCVector.h. r=jandem

Comment 5

[Alexandru Michis [:malexandru]]

Relanded changeset f76f3b0a3c9f since the failures linked in the backout comment are actually high frequency ones that by chance permafailed on that push, sorry for the inconvenience!

Reland link: https://hg.mozilla.org/integration/autoland/rev/0e79ef9f3dae29d61cdb42516c7c05f8d0c414fd

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0e79ef9f3dae