1713627 - Remove code that is no longer relevant without the Text Encoding submenu

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Bug 1687635 causes a whole lot of code become dead code. Let's remove that dead code.

Comment 1

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Attachment: Bug 1713627 - Remove code obsoleted by the replacing the Text Encoding menu with one item.

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

I expect this to have failures. Let's see which ones:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02e1596985ee579c6ada97d377be6959cdc11300

Comment 3

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=55c644dc0144669945c2d9b7578badbc64273e80

Comment 4

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e479f97785fe6f0736c03472c891d7338756c1ce

Comment 5

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05a0fca83868e8919cd79638f8ad50a5f40ddc25

Comment 6

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=39ef58b92b9cc798143120bcb351522e60172b6f

Comment 7

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

It turns out that a bunch of code that I expected to remove provides a theoretical protection that, strictly, isn't obsoleted by bug 1687635: If the detector causes a reload, we have code to ensure that if the document after reload has somehow changed to have different HTTP headers or metas, we still don't actuate a dangerous override.

That code causes enough complexity to address a theoretical threat that I want to remove that code, but let's do it in a different bug.

Comment 8

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

(In reply to Henri Sivonen (:hsivonen) from comment #7)

That code causes enough complexity to address a theoretical threat that I want to remove that code, but let's do it in a different bug.

Filed as bug 1716290.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4891a17c55e2
Remove code obsoleted by the replacing the Text Encoding menu with one item. r=jaws,emk

Comment 10

[Dorel Luca [:dluca]]

Backed out changeset 4891a17c55e2 (bug 1713627) for Browser-chrome failures in docshell/test/browser/browser_bug673087-1.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=343348068&repo=autoland&lineNumber=2543

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4891a17c55e2731f66fcaeb70e4884987c0120f5

Backout:
https://hg.mozilla.org/integration/autoland/rev/e7f85563dd3dab0183da9773713aa00ffac1fe28

Comment 11

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

The error is:

JavaScript error: resource://specialpowers/SpecialPowersChild.jsm, line 1562: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.getFunctionSourceLocation]

from

  spawn(target, args, task) {
    let browsingContext = this._browsingContextForTarget(target);

    return this.sendQuery("Spawn", {
      browsingContext,
      args,
      task: String(task),
      caller: Cu.getFunctionSourceLocation(task),
      hasHarness: typeof this.SimpleTest === "object",
      imports: this._spawnTaskImports,
    });
  }

Comment 12

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

When reducing the number of arguments for a testing function, I had failed to remove an argument passed by one caller. Pushed a trivial fix.

Comment 13

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

https://phabricator.services.mozilla.com/D116391?vs=451205&id=453056#toc

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/640ad102b316
Remove code obsoleted by the replacing the Text Encoding menu with one item. r=jaws,emk

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/640ad102b316

Comment 16

[José M. Muñoz]

Filed bug 1717523 for the C-C port.