1713690 - Improve the ETP shim for Google IMA3

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

The shim is currently just an empty script, but we can stub out the API more fully to prevent videos from breaking on a number of pages. Doing so will also allow us to trivialize our shim for AdSafeProtected's IMA Adapter, as the current special-case in that shim for nhl.com will no longer be needed, including its user opt-in mechanism.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1713690 - Improve the SmartBlock shimming for Google IMA3; r?denschub

• adds an actual shim for Google IMA3, rather than shimming with an empty file
• simplifies the AdSafeProtected IMA shim:
  • no longer needs to opt in to the original script for videos to play
  • it can now just be a basic stub shim for the API

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9fd6e652433
Improve the SmartBlock shimming for Google IMA3; r=denschub,webcompat-reviewers

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c9fd6e652433

Comment 4

[Thomas Wisniewski [:twisniewski]]

I just caught a bug with this caused by a mis-merge on my end. I'll upload and land the fix in a second patch here, since it's trivial.

Comment 5

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1713690 - fix a trivial mis-merge for the Google IMA SmartBlock shim; r?denschub

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07e585877340
fix a trivial mis-merge for the Google IMA SmartBlock shim; r=denschub,webcompat-reviewers

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/07e585877340