Closed
Bug 1713690
Opened 3 years ago
Closed 3 years ago
Improve the ETP shim for Google IMA3
Categories
(Core :: Privacy: Anti-Tracking, enhancement)
Core
Privacy: Anti-Tracking
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: twisniewski, Assigned: twisniewski)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The shim is currently just an empty script, but we can stub out the API more fully to prevent videos from breaking on a number of pages. Doing so will also allow us to trivialize our shim for AdSafeProtected's IMA Adapter, as the current special-case in that shim for nhl.com will no longer be needed, including its user opt-in mechanism.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
- adds an actual shim for Google IMA3, rather than shimming with an empty file
- simplifies the AdSafeProtected IMA shim:
- no longer needs to opt in to the original script for videos to play
- it can now just be a basic stub shim for the API
|
||
Updated•3 years ago
|
Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9fd6e652433 Improve the SmartBlock shimming for Google IMA3; r=denschub,webcompat-reviewers
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
|
Assignee | |
Comment 4•3 years ago
|
||
I just caught a bug with this caused by a mis-merge on my end. I'll upload and land the fix in a second patch here, since it's trivial.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Attachment #9230400 -
Attachment description: Bug 1713690 - fix a minor mis-merge for the Google IMA SmartBlock shim; r?denschub → Bug 1713690 - fix a trivial mis-merge for the Google IMA SmartBlock shim; r?denschub
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07e585877340 fix a trivial mis-merge for the Google IMA SmartBlock shim; r=denschub,webcompat-reviewers
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•