1713694 - Add an ETP shim for AddThis

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

Even just shimming it with an empty will prevent some sites from completely breaking.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1713694 - Add a SmartBlock shim for AddThis; r?denschub

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43af938350db
Add a SmartBlock shim for AddThis; r=denschub,webcompat-reviewers

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for eslint failure on data/shims.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=43af938350db8c4c554318d028710f2dd9bcfb9e&selectedTaskRun=GYH8AwfqQbuqnTiNTU8gYQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=348696507&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/07af90a66c5145ac740a6cafbb1f41c9bf03c4f2

Comment 4

[Thomas Wisniewski [:twisniewski]]

Pardon the bad merge! I've fixed the patch and will wait for SCA like a good boy this time!

Comment 5

[Narcis Beleuzu [:NarcisB]]

Please also check bc failures on browser_parsable_script.js -> https://treeherder.mozilla.org/logviewer?job_id=348700881&repo=autoland&lineNumber=2989

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60460b50e794
Add a SmartBlock shim for AddThis; r=denschub,webcompat-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/60460b50e794

Comment 8

[Thomas Wisniewski [:twisniewski]]

It turns out that we'll need to do something a bit different than expected to fix the breakage we're seeing with the AddThis widget's angular module; an empty script shim isn't sufficient. I have a follow-up patch ready which addresses this.

Comment 9

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1713694 - update the SmartBlock shim for AddThis to load an empty Angular module instead as needed; r?denschub

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31d44c4124c1
update the SmartBlock shim for AddThis to load an empty Angular module instead as needed; r=denschub,webcompat-reviewers

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/31d44c4124c1