1713734 - Pref gfx.webrender.force-disabled=true could not disable WebRender during pref gfx.webrender.all=true

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Sotaro Ikeda [:sotaro]]

It seems clearer if gfx.webrender.force-disabled is stronger preference than gfx.webrender.all.

Comment 1

[Sotaro Ikeda [:sotaro]]

The followings makes to prefer gfx.webrender.all.
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/gfx/config/gfxConfigManager.cpp#264
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/gfx/config/gfxConfigManager.cpp#136

Comment 2

[Sotaro Ikeda [:sotaro]]

With the following, webrender selection order becomes tricky. pref gfx.webrender.software has higher priority than env var.
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/taskcluster/taskgraph/transforms/tests.py#323
https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/gfx/config/gfxConfigManager.cpp#130

Comment 3

[Sotaro Ikeda [:sotaro]]

It seems that enabling/disabling software WebRender could be orthogonal problem than hardware WebRender.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1713734 - Make force-disable override gfx.webrender.all

Comment 5

[Sotaro Ikeda [:sotaro]]

force-disable was originally override other enabling prefs (gfx.webrender.enabled, gfx.webrender.all, and gfx.webrender.all.qualified).
https://searchfox.org/mozilla-central/rev/e9eb869e90a8d717678c3f38bf75843e345729ab/gfx/config/gfxConfigManager.cpp#267

Comment 6

[Jeff Muizelaar [:jrmuizel]]

I agree that it makes sense for force-disabled to be the stronger preference.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eff3f7bb9e9a
Make force-disable override gfx.webrender.all r=jrmuizel,aosmond,gfx-reviewers

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/eff3f7bb9e9a