Closed Bug 1713885 Opened 4 years ago Closed 4 years ago

Tests skipped in 'accessible/tests/browser/bounds/browser.ini' for new Fission platform triage

Categories

(Core :: Disability Access APIs, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Fission Milestone M7a
Tracking Status
firefox-esr78 --- disabled
firefox89 --- disabled
firefox90 --- disabled
firefox91 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

The following tests were disabled in accessible/tests/browser/bounds/browser.ini due to new Fission platform triage:
browser_test_zoom.js

Full diff:

# HG changeset patch
# User Andrew Halberstadt <ahal@mozilla.com>
# Date 1622223544 14400
#      Fri May 28 13:39:04 2021 -0400
# Node ID d2b0033a9d73556919f84b2dedbf2337accbe891
# Parent  bbb448a557b48a5e843f9a35f5dd74ea667326e5
Bug 1694824 - [ci] Annotate browser-chrome manifests for new fission failures, r?jmaher!

Differential Revision: https://phabricator.services.mozilla.com/D116276

diff --git a/accessible/tests/browser/bounds/browser.ini b/accessible/tests/browser/bounds/browser.ini
--- a/accessible/tests/browser/bounds/browser.ini
+++ b/accessible/tests/browser/bounds/browser.ini
@@ -4,11 +4,13 @@ support-files =
   !/accessible/tests/browser/shared-head.js
   !/accessible/tests/browser/*.jsm
   !/accessible/tests/mochitest/*.js
   !/accessible/tests/mochitest/letters.gif
 
 [browser_test_resolution.js]
 skip-if = e10s && os == 'win' # bug 1372296
 [browser_test_zoom.js]
+skip-if =
+  fission && debug && os == "mac"  # New platform triage
 [browser_test_zoom_text.js]
 skip-if = e10s && os == 'win' # bug 1372296
 [browser_zero_area.js]

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 accessible/tests/browser/bounds/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Blocks: 1694824
Fission Milestone: --- → M7a
Blocks: a11y-fission

I don't see this failure in the try run linked above. I pushed my own try run and I didn't get a failure there either. (I didn't need to remove the skip line because your patch isn't in central yet.) Is there something I'm missing here or can this be closed?

Flags: needinfo?(ahal)

My patch series also enabled the tasks in the first place, so your push didn't run the fission tasks in question. Here's a try push that should reproduce:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=40b17e0e5103c479f12689ab71ca57a5aa7a6ae6

I may have added extra annotations due to a bug in Push Health, that I only realized after the fact. So there's a good chance the annotation was added my mistake. If the above push is green, we can use this bug to remove the annotation. Sorry for the noise!

Flags: needinfo?(ahal)
Assignee: nobody → ahal
Status: NEW → ASSIGNED
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62c86f299591 Remove skip-if annotation in accessible/tests/browser/bounds/browser_test_zoom.js, r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: