1713889 - Tests skipped in 'browser/base/content/test/general/browser.ini' for new Fission platform triage

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Andrew Halberstadt [:ahal]]

The following tests were disabled in browser/base/content/test/general/browser.ini due to new Fission platform triage:
browser_save_video_frame.js
browser_clipboard.js

Full diff:

diff --git a/browser/base/content/test/general/browser.ini b/browser/base/content/test/general/browser.ini
--- a/browser/base/content/test/general/browser.ini
+++ b/browser/base/content/test/general/browser.ini
@@ -179,16 +183,18 @@ skip-if = os == 'linux' && !debug && bit
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug832435.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_bug882977.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_accesskeys.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_clipboard.js]
+skip-if =
+  fission && os == "win" && !debug  # New platform triage
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_clipboard_pastefile.js]
 skip-if = true # Disabled due to the clipboard not supporting real file types yet (bug 1288773)
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_contentAreaClick.js]
 skip-if = e10s # Clicks in content don't go through contentAreaClick with e10s.
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_contentAltClick.js]
@@ -280,16 +286,18 @@ skip-if = (e10s && debug && os == "win")
 [browser_save_private_link_perwindowpb.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_save_link_when_window_navigates.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_save_video.js]
 skip-if = (os == 'mac') || (verify && (os == 'mac')) || (os == 'win' && debug) || (os =='linux') #Bug 1212419
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_save_video_frame.js]
+skip-if =
+  fission && os == "win" && !debug  # New platform triage
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_selectTabAtIndex.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_star_hsts.js]
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.
 [browser_storagePressure_notification.js]
 skip-if = verify
 # DO NOT ADD MORE TESTS HERE. USE A TOPICAL DIRECTORY INSTEAD.

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 browser/base/content/test/general/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

Comment 1

[Chris Peterson [:cpeterson]]

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Comment 2

[Nika Layzell [:nika] (ni? for response)]

The browser_clipboard.js failure in https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fgeneral%2Fbrowser.ini&selectedTaskRun=Tv67QyVPQY63lsaLfuiPxg.0 appears to look very similar to bug 1512566 and might not be a fission failure, as it appears to be quite frequently failing on all windows10-64-qr opt platforms.

I couldn't find a failure for browser_save_video_frame.js on windows-opt, so I can't give any inisght into that particular failure.

Comment 3

[Chris Peterson [:cpeterson]]

I couldn't find a failure for browser_save_video_frame.js on windows-opt, so I can't give any inisght into that particular failure.

I see a browser_save_video_frame.js failure in this other Fission browser-chrome try run:

https://treeherder.mozilla.org/push-health/push?repo=try&revision=787ca6fe2e8486af2c29b52dfa0d31efbe47c705&testGroup=ki&selectedTest=browserbasecontenttestgeneralbrowsersavevideoframejs&selectedTaskId=341073882&selectedJobName=browser%2Fbase%2Fcontent%2Ftest%2Fgeneral%2Fbrowser_save_video_frame.js+test-windows10-64-qr%2Fdebug-mochitest-browser-chrome-fis-e10s-4

Note that the above failure is for Windows debug and this bug's skip-if annotation is for Windows opt.

Push Health says that browser_save_video_frame.js failure may be six-year old bug 1212419. The Intermittent Failures Robot posts about 1-4 intermittent (e10s) failures per week in that bug.

Unless Fission makes these failures much more frequent, I think we probably can consider them not Fission bugs and remove these new Fission annotation.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1713889 - Remove fission skip-ifs in browser/base/content/test/general/browser.ini, r?#intermittent-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9064ea55223b
Remove fission skip-ifs in browser/base/content/test/general/browser.ini, r=jmaher

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9064ea55223b