1713891 - Tests skipped in 'browser/base/content/test/protectionsUI/browser.ini' for new Fission platform triage

Status: RESOLVED FIXED

(Firefox :: Protections UI, task)

Description

[Andrew Halberstadt [:ahal]]

The following tests were disabled in browser/base/content/test/protectionsUI/browser.ini due to new Fission platform triage:
browser_protectionsUI.js

Full diff:

--- a/browser/base/content/test/protectionsUI/browser.ini
+++ b/browser/base/content/test/protectionsUI/browser.ini
@@ -7,17 +7,20 @@ support-files =
   cookiePage.html
   cookieSetterPage.html
   cookieServer.sjs
   embeddedPage.html
   trackingAPI.js
   trackingPage.html
 
 [browser_protectionsUI.js]
-skip-if = tsan # bug 1675107
+skip-if =
+  tsan # bug 1675107
+  fission && os == "mac" && debug  # New platform triage
+  fission && os == "linux" && asan  # New platform triage
 [browser_protectionsUI_3.js]
 [browser_protectionsUI_background_tabs.js]
 [browser_protectionsUI_categories.js]
 [browser_protectionsUI_cookies_subview.js]
 [browser_protectionsUI_cryptominers.js]
 [browser_protectionsUI_fetch.js]
 support-files =
   file_protectionsUI_fetch.html

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 browser/base/content/test/protectionsUI/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

Comment 1

[Chris Peterson [:cpeterson]]

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Comment 2

[Chris Peterson [:cpeterson]]

Prathiksha, I don't see any Fission failures in recent try runs for Fission browser-chrome (before these annotations were added). We've seen some other false positive bug reports for Fission browser-chrome tests, so we can probably just remove these new Fission annotations and see what happens.

https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/base/content/test/protectionsUI/browser.ini#14-18

[browser_protectionsUI.js]
skip-if =
  tsan # bug 1675107
  fission && os == "mac" && debug  # Bug 1713891 - new Fission platform triage
  fission && os == "linux" && asan  # Bug 1713891 - new Fission platform triage

Comment 3

[:prathiksha]

(In reply to Chris Peterson [:cpeterson] from comment #2)

Prathiksha, I don't see any Fission failures in recent try runs for Fission browser-chrome (before these annotations were added). We've seen some other false positive bug reports for Fission browser-chrome tests, so we can probably just remove these new Fission annotations and see what happens.

https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/base/content/test/protectionsUI/browser.ini#14-18

[browser_protectionsUI.js]
skip-if =
  tsan # bug 1675107
  fission && os == "mac" && debug  # Bug 1713891 - new Fission platform triage
  fission && os == "linux" && asan  # Bug 1713891 - new Fission platform triage

Sounds good.

Comment 4

[:prathiksha]

Attachment: WIP: Bug 1713891 - Re-enable protections dashboard tests for fission.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe8bcaf95a4
WIP: Bug 1713891 - Re-enable protections dashboard tests for fission. r=johannh

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/afe8bcaf95a4