1713898 - Stop skipping browser_experimental_features_filter.js for Fission on Windows opt builds

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Andrew Halberstadt [:ahal]]

The following tests were disabled in browser/components/preferences/tests/browser.ini due to new Fission platform triage:
browser_experimental_features_filter.js

Full diff:

diff --git a/browser/components/preferences/tests/browser.ini b/browser/components/preferences/tests/browser.ini
--- a/browser/components/preferences/tests/browser.ini
+++ b/browser/components/preferences/tests/browser.ini
@@ -14,16 +19,18 @@ support-files =
 [browser_advanced_update.js]
 skip-if = !updater
 [browser_basic_rebuild_fonts_test.js]
 [browser_bug410900.js]
 [browser_bug731866.js]
 [browser_bug1579418.js]
 [browser_experimental_features.js]
 [browser_experimental_features_filter.js]
+skip-if =
+  fission && os == "win" && !debug  # New platform triage
 [browser_experimental_features_hidden_when_not_public.js]
 [browser_experimental_features_resetall.js]
 [browser_filetype_dialog.js]
 [browser_search_no_results_change_category.js]
 [browser_search_within_preferences_1.js]
 skip-if = (os == 'win' && (processor == "x86_64" || processor == "aarch64")) # Bug 1480314, aarch64 due to 1536560
 [browser_search_within_preferences_2.js]
 [browser_search_within_preferences_command.js]

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 browser/components/preferences/tests/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

Comment 1

[Chris Peterson [:cpeterson]]

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'm confused. The link in comment 0 and comment 1 point to a try push that doesn't seem to show browser_experimental_features_filter.js running. According to the rule that was added, the test was skipped for Windows Fission non-debug builds, but I can't find browser_experimental_features_filter.js failing in any of the Windows opt builds. Am I missing it?

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)

I'm confused. The link in comment 0 and comment 1 point to a try push that doesn't seem to show browser_experimental_features_filter.js running. According to the rule that was added, the test was skipped for Windows Fission non-debug builds, but I can't find browser_experimental_features_filter.js failing in any of the Windows opt builds. Am I missing it?

Sorry about that! We have had a few false positive bugs filed for Fission browser-chrome test failures. I checked some of the earlier try test runs of Fission browser-chrome and I didn't see any browser_experimental_features_filter.js failures there either.

I can use this bug to simply remove the unnecessary Fission annotation:

https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/browser/components/preferences/tests/browser.ini#21-23

[browser_experimental_features_filter.js]
skip-if =
  fission && os == "win" && !debug  # Bug 1713898 - new Fission platform triage

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Bug 1713898 - Remove unnecessary `skip-if = fission` from browser_experimental_features_filter.js test. r?ahal

Comment 5

[Chris Peterson [:cpeterson]]

Here is a browser-chrome try run on Windows opt fis that doesn't show any failures for browser_experimental_features_filter.js after I removed the fission annotation:

https://treeherder.mozilla.org/jobs?repo=try&revision=ec7a5fafae729ea41c9afb5a921c62cb3942c0f5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c3ddaa1231c
Remove unnecessary `skip-if = fission` from browser_experimental_features_filter.js test. r=ahal,preferences-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3c3ddaa1231c