Open Bug 1713909 Opened 3 years ago Updated 2 years ago

Tests skipped in 'toolkit/components/antitracking/test/browser/browser.ini' for new Fission platform triage

Categories

(Core :: Privacy: Anti-Tracking, task, P3)

task

Tracking

()

Fission Milestone Future
Tracking Status
firefox-esr78 --- disabled
firefox89 --- disabled
firefox90 --- disabled
firefox91 --- affected

People

(Reporter: ahal, Unassigned)

References

Details

(Whiteboard: [fxatps-query-stripping])

The following tests were disabled in toolkit/components/antitracking/test/browser/browser.ini due to new Fission platform triage:
browser_urlQueryStringStripping.js

Full diff:

--- a/toolkit/components/antitracking/test/browser/browser.ini
+++ b/toolkit/components/antitracking/test/browser/browser.ini
@@ -135,16 +135,18 @@ support-files = matchAll.js
 support-files = sharedWorker.js partitionedSharedWorker.js
 [browser_PBMCookieBehavior.js]
 [browser_socialtracking.js]
 [browser_socialtracking_save_image.js]
 [browser_thirdPartyStorageRejectionForCORS.js]
 [browser_urlDecorationStripping.js]
 tags = remote-settings
 [browser_urlQueryStringStripping.js]
+skip-if =
+  fission && os == "linux" && asan  # New platform triage
 support-files = file_stripping.html
 [browser_staticPartition_cache.js]
 support-files =
   !/browser/components/originattributes/test/browser/file_cache.html
   !/browser/components/originattributes/test/browser/file_thirdPartyChild.audio.ogg
   !/browser/components/originattributes/test/browser/file_thirdPartyChild.embed.png
   !/browser/components/originattributes/test/browser/file_thirdPartyChild.fetch.html
   !/browser/components/originattributes/test/browser/file_thirdPartyChild.iframe.html

See the following try push for failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

To run these failures in your own try push, first revert the skip-if
annotations, then run:

$ ./mach try fuzzy --rebuild 3 toolkit/components/antitracking/test/browser/browser.ini

Then use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s). Please note the failure may be intermittent
and/or been fixed since the triage took place.

We need to determine whether this browser-chrome test failure should block shipping Fission. Tracking for Fission Milestone M7a for the initial audit. Then we can decide whether to move this bug to Fission M8 or post-MVP (Fission Future).

Here is a recent Try run for Fission browser-chrome:

https://treeherder.mozilla.org/jobs?repo=try&revision=ad7a18fdad3b8e35b44152c16d94babb80387cd8

Blocks: 1694824
Fission Milestone: --- → M7a

This test suite is currently being fully skipped on asan/tasn due to https://bugzilla.mozilla.org/show_bug.cgi?id=1662229, so I don't think we can do much about this particular test.

(In reply to Nika Layzell [:nika] (ni? for response) from comment #2)

This test suite is currently being fully skipped on asan/tasn due to https://bugzilla.mozilla.org/show_bug.cgi?id=1662229, so I don't think we can do much about this particular test.

In that case, I don't think this bug needs to block Fission M7a.

@ Tim, we can probably just remove this new Fission annotation and see what happens after Linux asan bug 1662229 is fixed.

https://searchfox.org/mozilla-central/rev/bf8d5de8528036c09590009720bc172882845b80/toolkit/components/antitracking/test/browser/browser.ini#144-146

[browser_urlQueryStringStripping.js]
skip-if =
  fission && os == "linux" && asan  # Bug 1713909 - new Fission platform triage
Fission Milestone: M7a → Future
Flags: needinfo?(tihuang)
See Also: → 1662229

Currently, the query stripping is just a prototype that is even disabled in Nightly. So I agree with that it doesn't block Fission.

(In reply to Chris Peterson [:cpeterson] from comment #3)

@ Tim, we can probably just remove this new Fission annotation and see what happens after Linux asan bug 1662229 is fixed.

LGTM

Flags: needinfo?(tihuang)
Whiteboard: [fxatps-query-stripping]
Severity: -- → N/A
Priority: -- → P2

This is specifically fission and linux and asan so shouldn't block us from releasing.

Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.